Fix storage_controller to show custom buttons #3629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ManageIQ#996 It cannot rely on @lastaction == 'show_list' because it's always 'explorer'. Introduced in ManageIQ/manageiq#11793
ZitaNemeckova
force-pushed
the
datastore_custom_buttons
branch
from
a7281e1 to
a1e490b
Compare
|
Checked commit ZitaNemeckova@a1e490b with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
@ZitaNemeckova Please add BZ link. |
|
@simaishi Added. Thanks :) |
|
@miq-bot add_label euwe/yes, fine/yes |
simaishi
pushed a commit
that referenced
this pull request
Mar 20, 2018
Fix storage_controller to show custom buttons (cherry picked from commit 3ccf3bd) https://bugzilla.redhat.com/show_bug.cgi?id=1558544
|
Gaprindashvili backport details: |
simaishi
added
gaprindashvili/backported
and removed
bugzilla needed
gaprindashvili/yes
labels
simaishi
pushed a commit
that referenced
this pull request
Apr 10, 2018
Fix storage_controller to show custom buttons (cherry picked from commit 3ccf3bd) https://bugzilla.redhat.com/show_bug.cgi?id=1565403
|
Fine backport details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #996
https://bugzilla.redhat.com/show_bug.cgi?id=1491832
Steps to reproduce:
Before:
After:
It cannot rely on
@lastaction == "show_list"because it's always"explorer". Introduced in ManageIQ/manageiq#11793@miq-bot add_label bug, toolbars, gaprindashvili/yes