Always use explorer layout in datastores screen #11793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The process_show_list() would change the previously set @lastaction to "show_list". We need to restore the explorer layout here, otherwise the datastores screen would be incorrectly rendered with a listnav controls on the left (rather than tree controls). https://bugzilla.redhat.com/show_bug.cgi?id=1381614
mzazrivec
force-pushed
the
always_use_explorer_layout_in_datastores_screen
branch
from
6da063f to
034195a
Compare
chessbyte
pushed a commit
that referenced
this pull request
Oct 13, 2016
…n_datastores_screen Always use explorer layout in datastores screen (cherry picked from commit 3992c4c) https://bugzilla.redhat.com/show_bug.cgi?id=1381614
|
Euwe Backport details: $ git log
commit b8ae2894c437c1abed1aeeae6beffe444d39186e
Author: Martin Povolny <[email protected]>
Date: Thu Oct 13 13:44:22 2016 +0200
Merge pull request #11793 from mzazrivec/always_use_explorer_layout_in_datastores_screen
Always use explorer layout in datastores screen
(cherry picked from commit 3992c4cc93da96a7c3c9cb97ff4f6e4e99166524)
https://bugzilla.redhat.com/show_bug.cgi?id=1381614 |
ZitaNemeckova
added a commit
to ZitaNemeckova/manageiq-ui-classic
that referenced
this pull request
Mar 15, 2018
Closes ManageIQ#996 It cannot rely on @lastaction == 'show_list' because it's always 'explorer'. Introduced in ManageIQ/manageiq#11793
ZitaNemeckova
added a commit
to ZitaNemeckova/manageiq-ui-classic
that referenced
this pull request
Mar 15, 2018
Closes ManageIQ#996 It cannot rely on @lastaction == 'show_list' because it's always 'explorer'. Introduced in ManageIQ/manageiq#11793
martinpovolny
pushed a commit
to martinpovolny/manageiq-ui-classic
that referenced
this pull request
Mar 19, 2018
Closes ManageIQ#996 It cannot rely on @lastaction == 'show_list' because it's always 'explorer'. Introduced in ManageIQ/manageiq#11793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
process_show_list()routine would change the previously set@lastactionto"show_list".We need to restore the explorer layout here, otherwise the datastores screen would be incorrectly
rendered with a listnav controls on the left (rather than tree controls).
As a side effect of this fix, the advanced search clear function will work correctly.
https://bugzilla.redhat.com/show_bug.cgi?id=1381614