OpsRbac - specs for user add/edit #3916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…success this was broken for a while before #3767, existing user could not be changed at all
on the one hand, these are tests written to check for specific regressions on the other, no other specs mention BZ numbers
|
@skateman I moved the methods to a helper, and removed the BZ numbers from the examples. => If anybody needs to know why a spec should not be failing, please read the relevant commit messages for BZ numbers. |
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/6f7f34ba7af4d14e6d08628fb6a77cdbe4a28ffa~...b6efd5e2afd9d3719312e5dc3276045099cb2850 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on ManageIQ/manageiq#17397Related to #3894, #3767, #3345 and #3714.
There's been too many problems recently with the code to add/edit a user in the UI - I've written specs for each of those problems (including a pending spec for the problem being fixed in #3894).
(Creating a new spec file, since
ops_controller/ops_rbac_spec.rbis already too long and only deals with tenant, while user/group stuff is either untested or mixed together with the rest inops_controller_spec.rb)Cc @lgalis , @ZitaNemeckova