Use update_attributes for saving a user's groups #3917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgalis
force-pushed
the
use_update_attributes_on_user_groups_save
branch
from
cb7ee05 to
3b574e7
Compare
|
@miq-bot add_label bug, settings, gaprindashvili/yes |
|
Checked commits lgalis/manageiq-ui-classic@3b574e7~...8cf6bbe with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
lgalis
changed the title
|
@h-kataria , @himdel - please see my last comment in #3894 - and we can merge either this PR or the 3894. |
|
Aaah, sorry for the delay .. I think this PR looks good, thanks! :) |
|
Tested in UI. LGTM 👍 |
|
Thanks for figuring this out @lgalis @himdel and @ZitaNemeckova |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use update_attributes for saving a user's groups. Alternative for #3894
Links
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1574634
Specs here: #3916