Towards provider plugins: dialog definition action #4377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzazrivec
changed the title
mzazrivec
reviewed
Jul 31, 2018
| allow(controller).to receive(:check_privileges).and_return(true) | ||
| end | ||
|
|
||
| let(:klass) { 'sorryjako' } |
mzazrivec
reviewed
Jul 31, 2018
| end | ||
|
|
||
| let(:klass) { 'sorryjako' } | ||
| let(:name) { 'kalousek' } |
mzazrivec
reviewed
Jul 31, 2018
|
|
||
| context 'existing dialog' do | ||
| it 'returns json with data' do | ||
| data = 'je to kampaň!' |
mzazrivec
reviewed
Aug 2, 2018
| end | ||
|
|
||
| context 'directory traversal' do | ||
| it 'ignores anything but [a-z_]'do |
There was a problem hiding this comment.
Missing whitespace before do
martinpovolny
force-pushed
the
dialog_definition
branch
2 times, most recently
from
7eb0988 to
9e178e6
Compare
skateman
suggested changes
Aug 3, 2018
| @@ -421,6 +421,77 @@ | |||
| end | |||
| end | |||
|
|
|||
| context '#dialog_definition' do | |||
| end | ||
| end | ||
|
|
||
| context 'private #load_dialog_definition' do |
There was a problem hiding this comment.
describe and you don't need the private
There was a problem hiding this comment.
The "private" is part of the description, surely I don't >>need<< it. But I want it.
| let (:name) { 'existing_dialog' } | ||
| let (:dialog_path) { Pathname.new("/dialogs/#{name}.json") } | ||
|
|
||
| before(:each) do |
| @@ -421,6 +421,77 @@ | |||
| end | |||
| end | |||
|
|
|||
| context '#dialog_definition' do | |||
| before(:each) do | |||
martinpovolny
force-pushed
the
dialog_definition
branch
from
9e178e6 to
33fc5e1
Compare
|
Some comments on commits martinpovolny/manageiq-ui-classic@1a1ee31~...33fc5e1 spec/controllers/dashboard_controller_spec.rb
|
|
Checked commits martinpovolny/manageiq-ui-classic@1a1ee31~...33fc5e1 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 spec/controllers/dashboard_controller_spec.rb
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increase version of react-ui-components (needed for demo).
Implement
/dashboars/dialog_definitionwith tests.Extracted from #4315 with added specs.