Remove ui plugin dialog-user call #7604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugins can still render react components, but removing the feature that allowed toolbar buttons with `dialog_name` to run automate dialogs. One less angular component, not currently used by any plugins.
|
cc @agrare |
|
Corresponding guides change in ManageIQ/guides#452 |
Fryguy
approved these changes
Jan 26, 2021
|
Checked commit https://github.com/himdel/manageiq-ui-classic/commit/174a0e57cfdeb248826fbb160c9dd61b8a7635e5 with ruby 2.6.3, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
Fryguy
reviewed
Jan 26, 2021
| def load_dialog_definition(name, klass) | ||
| plugin = Vmdb::Plugins.find { |plug| plug.name.chomp('::Engine') == klass } | ||
| if plugin.present? | ||
| name = plugin.root.join('dialogs', "#{name}.json") |
There was a problem hiding this comment.
This is the key line for me, because there aren't any plugins with a dialogs directory at the root.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI plugins can still render react components,
but removing the feature that allowed toolbar buttons with
dialog_nameto run angular automate dialogs.One less angular component, not currently used by any plugins.
Reverts #4377 and parts of #4315.