Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] Display Vm power state in the related grid views #4809

Merged
merged 1 commit into from
Oct 31, 2018

Conversation

skateman
Copy link
Member

@skateman skateman commented Oct 22, 2018

I looked for all the yaml reports containing Vm in their filename:

$ find product/views | grep Vm
product/views/VmdbIndex.yaml - irrelevant
product/views/ManageIQ_Providers_CloudManager_Vm-vms.yaml
product/views/VmdbDatabaseSetting.yaml - irrelevant
product/views/Vm.yaml
product/views/ManageIQ_Providers_CloudManager_Vm-all_vms_and_templates.yaml
product/views/Vm-all_vms.yaml
product/views/ManageIQ_Providers_Vmware_CloudManager_OrchestrationTemplate.yaml - irrelevant
product/views/VmOrTemplate.yaml
product/views/ManageIQ_Providers_InfraManager_Vm.yaml
product/views/VmOrTemplate-all_vms_and_templates.yaml
product/views/VmdbTableEvm.yaml - irrelevant
product/views/VmdbDatabaseConnection.yaml - irrelevant
product/views/VmOrTemplate-all_orphaned.yaml - orphaned is a power state
product/views/Vm-VmReconfigureRequest.yaml - reconfiguration doesn't need powerstate
product/views/ManageIQ_Providers_CloudManager_Vm.yaml
product/views/VmOrTemplate-all_archived.yaml - archived is a power state
product/views/Vm__restricted.yaml

Some of them were irrelevant, but all the others should be affected by this change.

Before:
screenshot from 2018-10-22 18-18-59

After:
screenshot from 2018-10-22 18-18-04

@miq-bot add_reviewer @epwinchell
@miq-bot add_label enhancement, GTLs

Depends on: ManageIQ/manageiq#18126
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1460798

@epwinchell
Copy link
Contributor

@skateman When sorting on the new powerstate column, the UI blows up
screen shot 2018-10-22 at 12 46 06 pm

@skateman
Copy link
Member Author

@epwinchell sorting fixed by ManageIQ/manageiq#18126
@miq-bot add_label pending core

@skateman
Copy link
Member Author

@miq-bot rm_label pending core
@epwinchell can you please retest, core PR is in.

@miq-bot
Copy link
Member

miq-bot commented Oct 30, 2018

Checked commit skateman@a12f6c3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. ⭐

@mzazrivec mzazrivec self-assigned this Oct 31, 2018
@mzazrivec mzazrivec added this to the Sprint 98 Ending Nov 5, 2018 milestone Oct 31, 2018
@mzazrivec mzazrivec merged commit 3445c5b into ManageIQ:master Oct 31, 2018
@skateman skateman deleted the vm-powerstate-gtl branch May 13, 2019 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants