[RFE] Implement normalized_state as a virtual_attribute for reporting #18126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skateman
force-pushed
the
virtual-normalized-state
branch
from
4ab5889 to
f907d23
Compare
skateman
force-pushed
the
virtual-normalized-state
branch
from
f907d23 to
8d9492d
Compare
|
Checked commit skateman@8d9492d with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Virtual attributes get complex quickly. But this looks good. Hope it improves performance for your report |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for ManageIQ/manageiq-ui-classic#4809 to allow sorting on screens based on
normalized_state.https://bugzilla.redhat.com/show_bug.cgi?id=1460798
@miq-bot add_reviewer @kbrock
@miq-bot add_reviewer @AlexanderZagaynov
@miq-bot add_reviewer @lpichler
@miq-bot add_label enhancement