Custom buttons for list views #796

martinpovolny · 2017-03-24T10:46:44Z

Adding custom button support for lists.

adding options when editing custom buttons
displaying custom toolbar or list screens
handling selection of multiple items by custom buttons
passing list of items to automate (partly, backend work needed to make all options work)

pivotal: https://www.pivotaltracker.com/story/show/140944305

I have disabled the "submit all" option in the UI as it is not (yet) supported by the backend.

himdel · 2017-04-10T14:23:59Z

app/assets/javascripts/miq_application.js

@@ -1484,6 +1484,10 @@ function miqToolbarOnClick(_e) {
      } else {
        params = miqSerializeForm(button.data('url_parms'));
      }
+    } else if (button.data('url_parms').match("id=LIST")) {


@vecerek You will need to handle this case in #642 :)

(The id=LIST is needed by backend, but doesn't have to imply miq_grid_checks in general, just for the buttons touched here..)

himdel · 2017-04-10T14:24:41Z

app/helpers/application_helper/toolbar_builder.rb

@@ -239,62 +245,68 @@ def create_custom_button_hash(input, record, options = {})
      :enabled   => options[:enabled],
      :klass     => ApplicationHelper::Button::ButtonWithoutRbacCheck,
      :url       => "button",
-      :url_parms => "?id=#{record.id}&button_id=#{button_id}&cls=#{record.class}&pressed=custom_button&desc=#{button_name}"
+      :url_parms => "?id=#{record_id}&button_id=#{button_id}&cls=#{model}&pressed=custom_button&desc=#{button_name}"


@vecerek .. Aand this will need send_checked (#642)

himdel · 2017-04-10T15:13:44Z

app/controllers/mixins/custom_buttons.rb

@@ -8,20 +8,23 @@ def custom_toolbar?
  end

  def custom_toolbar_explorer?


Should probably no longer have the question mark in the name, since it returns nil or a string :)

himdel · 2017-04-11T11:56:31Z

Verified in the UI checklist:

Cloud Tenant
Cluster / Deployment Role
Datastore - nope, but Datastore missing custom buttons? #996
Host / Node
Provider (but Provider dashboards missing custom buttons #999, Container Providers and Middleware Providers missing custom buttons #1000, and Custom buttons for list views #796 (comment))
Service
Template and Image (nope - Custom buttons for list views #796 (comment))
VM and Instance

himdel · 2017-04-11T12:03:40Z

When multiple items are selected (and for=list or both) it shows Error executing: "both" Not implemented. .. maybe something like Actions on multiple entities are not implemented.?

EDIT: aah, fixed when cb.options[:submit_how] = "one"

himdel · 2017-04-11T12:04:27Z

When no items are selected (and for=list or both), it dies with undefined method 'name' for nil:NilClass [cloud_tenant/button]

[NoMethodError] undefined method `name' for nil:NilClass
/home/himdel/manageiq-ui-classic/app/controllers/application_controller/buttons.rb:292:in `custom_buttons'
/home/himdel/manageiq-ui-classic/app/controllers/cloud_tenant_controller.rb:24:in `button'

EDIT: fixed, No item was selected.

himdel · 2017-04-11T13:18:02Z

@martinpovolny Looks like you may have missed Storage > {Block, Object} Storage > Managers - you can see the Provider custom buttons in detail view, but not in list view.

martinpovolny · 2017-04-11T13:23:52Z

@himdel : Do you think that this mergeable w/o those added? I'll follow up with a PR making sure that the buttons are displayed there too.

himdel · 2017-04-11T13:27:44Z

@martinpovolny Sure, no problem with that :).

Another bug..

Go to Compute > Clouds > Instances
accordion Images by Provider or Images
pick one in the list, click a list or both button
Error executing custom button: No item was selected.

(Works in the detail for the same thing.)

The same happens in Compute > Infrastructure > Virtual Machines, accordion Templates, and also happens in the "VMs & Templates" accordion when a Template is selected.

... so, any templates or images in list view.

(Not sure if it makes sense to merge without this one..?)

martinpovolny · 2017-04-11T15:35:57Z

Looking into it. I am not sure what is the desired behavior here. It's probably not going to be a quick fix.

martinpovolny · 2017-04-11T19:25:32Z

  def toolbar_class(toolbar_name)                                                                   
    if Mixins::CustomButtons::Result === toolbar_name                                               
      model = @record ? @record.class : controller.class.model                                      
      custom_....

Holy crappa. This is much complex, because for the explorer-based controller and lists being displayed the class of the elements displayed depends on the node selected in the tree. Not just simply controller.class.model :-(

There needs to be some logic that will tell the class of the stuff being shown in the GTL and that needs to be called for the custom toolbar.

…m the list being displayed.

martinpovolny · 2017-04-12T08:48:24Z

@martinpovolny Looks like you may have missed Storage > {Block, Object} Storage > Managers - you can see the Provider custom buttons in detail view, but not in list view.

@himdel : as for these: I don't have data to test or debug this, do you?
But reading the code: neither app/controllers/ems_object_storage_controller.rb nor app/controllers/ems_block_storage_controller.rb include has_custom_buttons line so there should be no custom toolbars. Of course unless there's some crazy exception logic somehwere that I have not found.

There's has_custom_buttons in ems_storage_controller however. But I have no idea, how to access that controller :-(

To the point: I think I have fixed the issue that you have found and that has been a blocker here. For the issues about storages I think I need more input from the managers. I have no idea how that is supposed to work :-(

miq-bot · 2017-04-12T09:08:33Z

Checked commits martinpovolny/manageiq-ui-classic@5fd1d21~...19f4fe9 with ruby 2.2.6, rubocop 0.47.1, and haml-lint 0.20.0
11 files checked, 4 offenses detected

app/helpers/application_helper/toolbar_builder.rb

❗ - Line 68, Col 38 - Style/CaseEquality - Avoid the use of the case equality operator ===.

app/views/shared/buttons/_ab_form.html.haml

⚠️ - Line 59 - Line is too long. [169/160]

app/views/shared/buttons/_ab_show.html.haml

⚠️ - Line 41 - Comment should have a space after the #
⚠️ - Line 41 - Missing space after #.

himdel · 2017-04-13T13:08:39Z

LGTM, tested in the UI 👍.

The only screen this does not work on (except for the separate issues linked above), is the VMs & Templates accordion in infra.. but.. well, we have no custom buttons for VmOrTemplate, so it makes sense :). And it does work in the VMs and Templates accorddions, and in single-item views in VMs & Templates.

himdel · 2017-04-13T13:09:56Z

@martinpovolny is this fine/yes?

Custom buttons for list views (cherry picked from commit 631a325)

simaishi · 2017-04-13T19:59:42Z

Fine backport details:

$ git log -1
commit 5765bd9c0decf6140a3a06c18db2c048428bbe67
Author: Martin Hradil <[email protected]>
Date:   Thu Apr 13 13:04:42 2017 +0000

    Merge pull request #796 from martinpovolny/custom_buttons_list
    
    Custom buttons for list views
    (cherry picked from commit 631a3259f26d2a6b0aa38cc5d14f17fbe3ac56e2)

martinpovolny added enhancement euwe/no wip labels Mar 24, 2017

miq-bot removed the wip label Mar 24, 2017

martinpovolny changed the title ~~[WIP Custom buttons for list views~~ [WIP] Custom buttons for list views Mar 25, 2017

miq-bot added the wip label Mar 25, 2017

martinpovolny force-pushed the custom_buttons_list branch 2 times, most recently from f26b61f to 8c6ee08 Compare March 31, 2017 08:31

martinpovolny force-pushed the custom_buttons_list branch 2 times, most recently from 33b39f1 to b5aab53 Compare April 10, 2017 11:55

martinpovolny changed the title ~~[WIP] Custom buttons for list views~~ Custom buttons for list views Apr 10, 2017

martinpovolny removed the wip label Apr 10, 2017

martinpovolny assigned himdel Apr 10, 2017

himdel reviewed Apr 10, 2017

View reviewed changes

himdel mentioned this pull request Apr 10, 2017

[WIP] miqToolbarOnClick - use explicit param send_checked #642

Closed

martinpovolny closed this Apr 11, 2017

martinpovolny reopened this Apr 11, 2017

martinpovolny added 11 commits April 11, 2017 10:45

Add custom button options for list view support.

5fd1d21

Toolbar: submit list of checked items for custom buttons.

807b3b1

Enable custom button toolbar for list views.

4b5a8d3

Add list support to custom button toolbar/button creation.

7e24e68

Add list support to custom button click action handling.

7328d73

Replace find_by_id with find to make Rubocop happy.

63c28d6

Fix custom_button specs to match added arguments.

59abac3

Differenciate custom buttons for lists and single item.

4afe315

Custom buttons: temporary disable submit_how:all.

7ad4907

Custom buttons: remove forgotten "pry".

7b571ec

Custom buttons: handle situation where @view_context is a controller.

4d6656c

martinpovolny force-pushed the custom_buttons_list branch from 6e3aabc to 6834d56 Compare April 11, 2017 08:54

CustomButtons: remove question marks from custom_toolbar*?.

2f087b5

martinpovolny force-pushed the custom_buttons_list branch from b6408ee to 2f087b5 Compare April 11, 2017 09:41

Custom buttons: fixes for zero items and default submit type.

0a95184

CustomToolbar: for plural case the record class needs to be taken fro…

7816308

…m the list being displayed.

martinpovolny force-pushed the custom_buttons_list branch from 76cffec to 7816308 Compare April 12, 2017 08:27

CustomButtons: rubocop fixes.

19f4fe9

himdel added this to the Sprint 59 Ending Apr 24, 2017 milestone Apr 13, 2017

himdel added the toolbars label Apr 13, 2017

himdel merged commit 631a325 into ManageIQ:master Apr 13, 2017

martinpovolny added the fine/yes label Apr 13, 2017

simaishi pushed a commit that referenced this pull request Apr 13, 2017

Merge pull request #796 from martinpovolny/custom_buttons_list

5765bd9

Custom buttons for list views (cherry picked from commit 631a325)

simaishi added fine/backported and removed fine/yes labels Apr 13, 2017

martinpovolny mentioned this pull request Apr 25, 2017

Custom Buttons: Submit multiple objects to automate at once ManageIQ/manageiq#14877

Closed

martinpovolny mentioned this pull request Jun 20, 2017

Custom button submit all #1572

Merged

martinpovolny deleted the custom_buttons_list branch November 28, 2017 18:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Custom buttons for list views #796

Custom buttons for list views #796

martinpovolny commented Mar 24, 2017 •

edited

Loading

himdel Apr 10, 2017

himdel Apr 10, 2017

himdel Apr 10, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017

martinpovolny commented Apr 11, 2017

himdel commented Apr 11, 2017 •

edited

Loading

martinpovolny commented Apr 11, 2017

martinpovolny commented Apr 11, 2017 •

edited

Loading

martinpovolny commented Apr 12, 2017

miq-bot commented Apr 12, 2017

himdel commented Apr 13, 2017 •

edited

Loading

himdel commented Apr 13, 2017

simaishi commented Apr 13, 2017

		@@ -8,20 +8,23 @@ def custom_toolbar?
		end

		def custom_toolbar_explorer?

Custom buttons for list views #796

Custom buttons for list views #796

Conversation

martinpovolny commented Mar 24, 2017 • edited Loading

himdel Apr 10, 2017

Choose a reason for hiding this comment

himdel Apr 10, 2017

Choose a reason for hiding this comment

himdel Apr 10, 2017 • edited Loading

Choose a reason for hiding this comment

himdel commented Apr 11, 2017 • edited Loading

himdel commented Apr 11, 2017 • edited Loading

himdel commented Apr 11, 2017 • edited Loading

himdel commented Apr 11, 2017

martinpovolny commented Apr 11, 2017

himdel commented Apr 11, 2017 • edited Loading

martinpovolny commented Apr 11, 2017

martinpovolny commented Apr 11, 2017 • edited Loading

martinpovolny commented Apr 12, 2017

miq-bot commented Apr 12, 2017

himdel commented Apr 13, 2017 • edited Loading

himdel commented Apr 13, 2017

simaishi commented Apr 13, 2017

martinpovolny commented Mar 24, 2017 •

edited

Loading

himdel Apr 10, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 11, 2017 •

edited

Loading

martinpovolny commented Apr 11, 2017 •

edited

Loading

himdel commented Apr 13, 2017 •

edited

Loading