Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated support for launching cockpit and console #1132

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Updated support for launching cockpit and console #1132

merged 1 commit into from
Oct 23, 2017

Conversation

chalettu
Copy link
Contributor

@miq-bot
Copy link
Member

miq-bot commented Oct 23, 2017

Checked commit https://github.com/chalettu/manageiq-ui-service/commit/63f968638bf5ba2dbb67ceb416862015957c58b7 with ruby 2.3.3, rubocop 0.47.1, and haml-lint 0.20.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@chriskacerguis chriskacerguis self-assigned this Oct 23, 2017
@chalettu
Copy link
Contributor Author

@miq-bot remove_label fine/no
@miq-bot add_label fine/yes

@miq-bot miq-bot added fine/yes and removed fine/no labels Oct 23, 2017
@chriskacerguis chriskacerguis merged commit 55d7c0f into ManageIQ:master Oct 23, 2017
@chriskacerguis chriskacerguis added this to the Sprint 72 Ending Oct 30, 2017 milestone Oct 23, 2017
@chrispy1
Copy link

@miq-bot add_label blocker

@simaishi
Copy link
Contributor

@chalettu This can be backported to Euwe branch?

@chriskacerguis
Copy link
Contributor

for the record, no this cannot be backported to Euwe. I'll make a PR to the Euwe branch.

@AllenBW AllenBW mentioned this pull request Oct 26, 2017
Merged
@simaishi
Copy link
Contributor

simaishi commented Nov 28, 2017 •
edited
Loading

@chalettu Can you confirm Fine should use supports_cockpit (not supports_launch_cockpit)? I know there were lots of discussion around what version uses what... so I want to make sure I can resolve conflicts by just moving supports_cockpit from attributes to decorators.

@chalettu chalettu deleted the bz-1471158-2 branch January 10, 2018 19:55
@AllenBW
Copy link
Member

AllenBW commented Jan 12, 2018

Okie dokie @simaishi #1282 is the one that fixes this for fine

@miq-bot miq-bot added fine/no and removed fine/no labels Jan 12, 2018
@simaishi
Copy link
Contributor

Removed fine/yes label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chriskacerguis chriskacerguis chriskacerguis approved these changes

@AllenBW AllenBW AllenBW approved these changes

Assignees
No one assigned
Labels
blocker bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chalettu @miq-bot @chrispy1 @simaishi @chriskacerguis @AllenBW