Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FINE] Adds supported_consoles attribute and related changes #1282

Merged
merged 1 commit into from
Dec 12, 2017

Conversation

AllenBW
Copy link
Member

@AllenBW AllenBW commented Nov 28, 2017

this is a copy of #1280 for fine

WIP till ManageIQ/manageiq#16589

@AllenBW AllenBW added the bug label Nov 28, 2017
@AllenBW AllenBW added the wip label Nov 28, 2017
@AllenBW AllenBW assigned simaishi and unassigned AllenBW and simaishi Nov 28, 2017
@AllenBW AllenBW changed the title #1280 for Fine [WIP][FINE]#1280 for Fine Nov 28, 2017
@AllenBW AllenBW force-pushed the bug/fine/#1471158-console_supported branch from 5f54d60 to 59a601f Compare November 28, 2017 21:44
@miq-bot
Copy link
Member

miq-bot commented Nov 28, 2017

Checked commit AllenBW@59a601f with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 👍

@AllenBW AllenBW changed the title [WIP][FINE]#1280 for Fine [WIP][FINE]#1280 pr for FINE, adds supported_consoles attribute and related changes Nov 29, 2017
@AllenBW AllenBW changed the title [WIP][FINE]#1280 pr for FINE, adds supported_consoles attribute and related changes [FINE]#1280 pr for FINE, adds supported_consoles attribute and related changes Dec 7, 2017
@AllenBW AllenBW requested a review from himdel December 7, 2017 21:39
@AllenBW AllenBW removed the wip label Dec 7, 2017
@AllenBW
Copy link
Member Author

AllenBW commented Dec 7, 2017

@himdel Looks like the backend pr needed for this was approved, ready for you at your earliest!

@AllenBW AllenBW added this to the Sprint 75 Ending Dec 11, 2017 milestone Dec 7, 2017
@simaishi simaishi changed the title [FINE]#1280 pr for FINE, adds supported_consoles attribute and related changes [FINE] Adds supported_consoles attribute and related changes Dec 7, 2017
Copy link
Contributor

@himdel himdel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants