Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename the osp_ attributes to reflect that they are id's #680

Merged
merged 1 commit into from
Oct 2, 2018
Merged

Rename the osp_ attributes to reflect that they are id's #680

merged 1 commit into from
Oct 2, 2018

Conversation

AparnaKarve
Copy link
Contributor

@AparnaKarve AparnaKarve commented Oct 2, 2018 •
edited
Loading

Rename the osp_ attributes to reflect that they are id's, in order to stay consistent with the backend naming convention

Related PR - ManageIQ/manageiq#18045

@AparnaKarve AparnaKarve mentioned this pull request Oct 2, 2018
Merged
@miq-bot
Copy link
Member

miq-bot commented Oct 2, 2018

Checked commit AparnaKarve@df55626 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

michaelkro
michaelkro approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎊

@michaelkro michaelkro merged commit 6b04c84 into ManageIQ:master Oct 2, 2018
simaishi pushed a commit that referenced this pull request Oct 3, 2018
@michaelkro @simaishi
Merge pull request #680 from AparnaKarve/osp_attribs_to_ids
7cf36e8 
Rename the `osp_` attributes to reflect that they are id's

(cherry picked from commit 6b04c84)
@simaishi
Copy link
Contributor

simaishi commented Oct 3, 2018

Hammer backport details:

$ git log -1
commit 7cf36e8f6dbdf7ffc693ee826b5bbb42e717f6d3
Author: Michael Ro <[email protected]>
Date:   Tue Oct 2 14:51:15 2018 -0400

    Merge pull request #680 from AparnaKarve/osp_attribs_to_ids
    
    Rename the `osp_` attributes to reflect that they are id's
    
    (cherry picked from commit 6b04c849614ff5c409ea44dc20eba81680e618ff)

@AparnaKarve AparnaKarve deleted the osp_attribs_to_ids branch October 3, 2018 13:23
@AparnaKarve AparnaKarve mentioned this pull request Oct 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelkro michaelkro michaelkro approved these changes

Assignees
No one assigned
Labels
hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AparnaKarve @miq-bot @simaishi @michaelkro