Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OSP attribute names #693

Merged
merged 1 commit into from
Oct 8, 2018
Merged

Fix OSP attribute names #693

merged 1 commit into from
Oct 8, 2018

Conversation

AparnaKarve
Copy link
Contributor

The changes here should have been part of #680 ideally

@AparnaKarve AparnaKarve force-pushed the fix_osp_attrib_names branch from c350730 to 35b49c3 Compare October 5, 2018 22:18
@miq-bot
Copy link
Member

miq-bot commented Oct 5, 2018

Checked commit AparnaKarve@35b49c3 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍰

michaelkro
michaelkro approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@michaelkro michaelkro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, good catch! 🎊

@AparnaKarve
Copy link
Contributor Author

@michaelkro @mturley Can you merge this?
Otherwise the OSP values are not going to look right in the Wizard in the Edit mode.
Thanks.

mturley
mturley approved these changes Oct 8, 2018
View reviewed changes
Copy link
Contributor

@mturley mturley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mturley mturley merged commit 4eefa0e into ManageIQ:master Oct 8, 2018
@AparnaKarve AparnaKarve deleted the fix_osp_attrib_names branch October 8, 2018 19:51
simaishi pushed a commit that referenced this pull request Oct 8, 2018
@mturley @simaishi
Merge pull request #693 from AparnaKarve/fix_osp_attrib_names
5b5c3ca 
Fix OSP attribute names

(cherry picked from commit 4eefa0e)
@simaishi
Copy link
Contributor

simaishi commented Oct 8, 2018

Hammer backport details:

$ git log -1
commit 5b5c3cad2eb2941aca58068f24a8553140c4f4b4
Author: Mike Turley <[email protected]>
Date:   Mon Oct 8 15:51:32 2018 -0400

    Merge pull request #693 from AparnaKarve/fix_osp_attrib_names
    
    Fix OSP attribute names
    
    (cherry picked from commit 4eefa0ea1745fe60fae356e861ea75eb1d6dd2e6)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mturley mturley mturley approved these changes

@michaelkro michaelkro michaelkro approved these changes

Assignees
No one assigned
Labels
hammer/backported
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AparnaKarve @miq-bot @simaishi @mturley @michaelkro