No revert for "active" snapshot #12768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the snapshot screen when the "active" snapshot is selected the revert button should be disabled. https://bugzilla.redhat.com/show_bug.cgi?id=1396068
|
Checked commit borod108@75e22a8 with ruby 2.2.5, rubocop 0.37.2, and haml-lint 0.16.1 |
|
@masayag please review. |
masayag
approved these changes
Nov 21, 2016
durandom
reviewed
Dec 1, 2016
| @@ -928,6 +928,7 @@ def disable_button(id) | |||
| when "vm_snapshot_delete_all" | |||
| return @record.is_available_now_error_message(:remove_all_snapshots) unless @record.is_available?(:remove_all_snapshots) | |||
| when "vm_snapshot_revert" | |||
| return N_("Select a snapshot that is not the active one") if @active | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
I do not see how, it does not seem to know @Active there.
There was a problem hiding this comment.
Oh, so @active is a UI toolbar thing?
There was a problem hiding this comment.
if comes from the controller and looks pretty spaghetti
|
@martinpovolny LGTM - please merge @miq-bot assign @martinpovolny |
simaishi
pushed a commit
that referenced
this pull request
Jan 9, 2017
No revert for "active" snapshot (cherry picked from commit eb0315d) https://bugzilla.redhat.com/show_bug.cgi?id=1402992
|
Euwe backport details: |
agrare
added a commit
to agrare/manageiq
that referenced
this pull request
Feb 16, 2017
…evert_active" This reverts commit 7898c8e. https://bugzilla.redhat.com/show_bug.cgi?id=1402992
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the snapshot screen when the "active" snapshot is selected
the revert button should be disabled.
https://bugzilla.redhat.com/show_bug.cgi?id=1396068