Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No revert for "active" snapshot #12768

Merged
merged 1 commit into from
Dec 6, 2016
Merged

No revert for "active" snapshot #12768

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions app/helpers/application_helper/toolbar_builder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -928,6 +928,7 @@ def disable_button(id)
when "vm_snapshot_delete_all"
return @record.is_available_now_error_message(:remove_all_snapshots) unless @record.is_available?(:remove_all_snapshots)
when "vm_snapshot_revert"
return N_("Select a snapshot that is not the active one") if @active
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be added here https://github.com/durandom/manageiq/blob/06c8bc3d189fc6277cd4933bb274e02d654badb0/app/models/manageiq/providers/redhat/infra_manager/vm/operations/snapshot.rb#L50-L50
?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not see how, it does not seem to know @Active there.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, so @active is a UI toolbar thing?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if comes from the controller and looks pretty spaghetti

return @record.is_available_now_error_message(:revert_to_snapshot) unless @record.is_available?(:revert_to_snapshot)
end
when "MiqTemplate"
Expand Down