-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CodeArena] - [L-04] : Add totalWeights 0 check #51
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CodeArena] - Issue 45 : Use += (coding style)
[CodeArena] - Issue 14 : Require messages shorten to fit in 32 bytes
[CodeArena] - Issue 46 : TotalWeights subtraction unchecked
[CodeArena] - Issue 199 : Add missing reserve checks
[CodeArena] - Issue 178 : Constructor parameters validation
[CodeArena] - Issues 3, 4 & 35 : More efficient ZeroExOperator
adrien-supizet
suggested changes
Dec 2, 2021
maximebrugel
force-pushed
the
codearena-43
branch
from
December 2, 2021 16:22
ff93299
to
47cf8c0
Compare
maximebrugel
force-pushed
the
codearena-43
branch
from
December 2, 2021 17:02
47cf8c0
to
35bd009
Compare
adrien-supizet
force-pushed
the
codearena
branch
from
December 2, 2021 17:05
7d787cc
to
5f79a38
Compare
maximebrugel
changed the title
[CodeArena] - Issue 43 : Add totalWeights 0 check
[CodeArena] - [L-04] : Add totalWeights 0 check
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue => code-423n4/2021-11-nested-findings#43