[CodeArena] - [G-26] : Remove double reading of state variable

[maximebrugel]

Issue => code-423n4/2021-11-nested-findings#98

[adrien-supizet]

I see the issue is marked question did you figure out the answer?

[maximebrugel]

I see the issue is marked question did you figure out the answer?

@adrien-supizet no, the auditor is anon 🤷🏻‍♂️ (impossible to reach)

[maximebrugel]

@adrien-supizet Should we try to get an answer or skipping this part of the issue ?

[adrien-supizet]

@adrien-supizet Should we try to get an answer or skipping this part of the issue ?

If you kind of understand the issue mentioned, let's discuss it and try to figure it out. Otherwise let's skip it.

[maximebrugel]

Just found out :

 for (uint256 i = 0; i < requiredAddresses.length; i++) {
    bytes32 name = requiredAddresses[i];    
    // Note: can only be invoked once the resolver has all the targets needed added     
    address destination = resolver.getAddress(name);
    if (destination != address(0)) {
        addressCache[name] = destination;
    } else {
        delete addressCache[name];
    }
    emit CacheUpdated(name, destination);
}

We must extract the variable name and destination (to be declared once outside of the loop).

[maximebrugel]

@adrien-supizet The rebuildCache fix is already done => #61

Just also extracted address cacheTmp;. it can be reviewed.