Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CodeArena] - [G-26] : Remove double reading of state variable #78

Merged
merged 1 commit into from
Jan 5, 2022
Merged

[CodeArena] - [G-26] : Remove double reading of state variable #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions contracts/MixinOperatorResolver.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,13 @@ abstract contract MixinOperatorResolver {
/// @notice Check the state of addressCache
function isResolverCached() external view returns (bool) {
bytes32[] memory requiredAddresses = resolverAddressesRequired();
bytes32 name;
address cacheTmp;
for (uint256 i = 0; i < requiredAddresses.length; i++) {
bytes32 name = requiredAddresses[i];
name = requiredAddresses[i];
cacheTmp = addressCache[name];
// false if our cache is invalid or if the resolver doesn't have the required address
if (resolver.getAddress(name) != addressCache[name] || addressCache[name] == address(0)) {
if (resolver.getAddress(name) != cacheTmp || cacheTmp == address(0)) {
return false;
}
}
Expand Down