Add docker for index meta-database #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CasperWA
force-pushed
the
add_docker_for_index_meta_db
branch
3 times, most recently
from
b234f3b to
98219df
Compare
|
This now creates two docker-compose services, i.e., two images. One is for the index meta-database (called |
CasperWA
force-pushed
the
add_docker_for_index_meta_db
branch
2 times, most recently
from
370807e to
71bb485
Compare
CasperWA
force-pushed
the
add_docker_for_index_meta_db
branch
3 times, most recently
from
df60bb2 to
f98c055
Compare
CasperWA
force-pushed
the
add_docker_for_index_meta_db
branch
from
f98c055 to
c5ec729
Compare
ml-evs
requested changes
Feb 6, 2020
Co-authored-by: Casper Welzel Andersen <[email protected]>
Update docker-compose to start both servers. Add CI check for building the Docker containers.
Now we are testing not only if it can be built, but also start both servers and test to see if we get an expected response.
There are now two ways to start the index meta-database server, instead of the regular server. 1. Run: ./run.sh index 2. Set variable: export MAIN="main_index" And then run normally. The two methods are also prioritized this way, i.e., if the environment variable MAIN="main", but one runs ./run.sh index, then the index meta-database will be started instead of the regular server.
CasperWA
force-pushed
the
add_docker_for_index_meta_db
branch
from
c5ec729 to
8d39011
Compare
ml-evs
reviewed
Feb 7, 2020
ml-evs
approved these changes
Feb 7, 2020
Merged
CasperWA
added a commit
that referenced
this pull request
Feb 13, 2020
Bump to v0.5.0 Changes: - Possibility for Docker deployment for both the index meta-database server as well as the regular server (#140, @ltalirz, @CasperWA) - Test building and starting Docker images with GitHub Actions CI (#140, @CasperWA, @ml-evs, @ltalirz) - Remove `/index` from the index meta-database's base URL (#140, @ltalirz, @CasperWA) - `include` query parameter (#163, @CasperWA) - Rename `optimade/server/deps.py` to `optimade/server/query_params.py` (#163, @CasperWA) - Human-readable landing page for versioned base URLs, as well as for `/optimade` (#172, @ml-evs) - Move mapper aliases to config file and out of mapper classes (#175, @ml-evs) Bug fixes: - Properly build versioned base URLs (#178, @CasperWA)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Going from the
index_meta_dbbranch from @ltalirz's fork, this adds a Dockerfile to the repository and a docker-compose file that should start both servers.Furthermore, a CI check has been added to test the Docker build.