-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly create optional versioned base URLs #178
Conversation
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=======================================
Coverage 86.31% 86.31%
=======================================
Files 40 40
Lines 1878 1878
=======================================
Hits 1621 1621
Misses 257 257
Continue to review full report at Codecov.
|
I think we should make this fix right now, if you wanted to ping the docker to make sure the current versions are up (e.g. The next thing to add to the validator is support for validating optional features, where one could be taking the API version from |
Already putting together this commit.
Nice idea! |
Made it so that the CI yml file is updated according to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks perfect to me now, cheers @CasperWA.
Bump to v0.5.0 Changes: - Possibility for Docker deployment for both the index meta-database server as well as the regular server (#140, @ltalirz, @CasperWA) - Test building and starting Docker images with GitHub Actions CI (#140, @CasperWA, @ml-evs, @ltalirz) - Remove `/index` from the index meta-database's base URL (#140, @ltalirz, @CasperWA) - `include` query parameter (#163, @CasperWA) - Rename `optimade/server/deps.py` to `optimade/server/query_params.py` (#163, @CasperWA) - Human-readable landing page for versioned base URLs, as well as for `/optimade` (#172, @ml-evs) - Move mapper aliases to config file and out of mapper classes (#175, @ml-evs) Bug fixes: - Properly build versioned base URLs (#178, @CasperWA)
Fixes #177
Concerning testing this, it is quite difficult for the way our test-setup works at the moment.
We could add an extra test for the docker CI tests, but it is perhaps not the correct place?