Resolving transaction conflicts in the discovery domain

[aryanjassal]

Description

Occasionally, a ErrorDBTransactionConflict is omitted from a background task checkForRediscoveryHandler. This should be properly locking a transaction and concurrent modification should be impossible.

This PR aims to figure out and eradicate the cause for this warning.

Issues Fixed

• Relates to Occasional ErrorDBTransactionConflict if the agent is left running for a while Polykey-CLI#353 (REF ENG-511)

Tasks

• 1. Resolve ErrorDBTransactionConflict in Discovery.checkForRediscoveryHandler

Final checklist

• Domain specific tests
• Full tests
• Updated inline-comment documentation
• Lint fixed
• Squash and rebased
• Sanity check the final build

[linear]

ENG-511 Occasional `ErrorDBTransactionConflict` if the agent is left running for a while

[aryanjassal]

When I applied a simple change of properly extracting the gestaltIdEncoded from an array, the syncNodeGraphHandler fails. And this change still has the DBTransactionConflict. So I would need to do a bit more research to actually resolve this.

pid       	933361
nodeId    	vet1dhoduhkmn4749r8usiopivklr8i4qoh9kjnhtgeg5rie4nvh0
clientHost	::1
clientPort	38573
agentHost 	::
agentPort 	39793
WARN:polykey.PolykeyAgent.task v0ps9qrcqapo01bq69ce6vhp398:Failed - Reason: ErrorNodeManagerSyncNodeGraphFailed("Failed to establish any connections with the following errors '[ErrorNodeConnectionTimeout()>AggregateError: All promises were rejected,ErrorNodeConnectionTimeout()>AggregateError: All promises were rejected]'")>AggregateError, Handler: NodeManager.syncNodeGraphHandler
WARN:polykey.PolykeyAgent.task v0ps9qihjq9o01a3rgl422osjhc:Failed - Reason: ErrorDBTransactionConflict, Handler: Discovery.checkForRediscoveryHandler