Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolving transaction conflicts in the discovery domain #858

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from
Draft

Resolving transaction conflicts in the discovery domain #858

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/discovery/Discovery.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ class Discovery {
}
}
await Promise.all(taskPromises);
this.logger.info(`Stopped all tasks for ${this.constructor.name}`);
this.taskManager.deregisterHandler(this.discoverVertexHandlerId);
this.taskManager.deregisterHandler(this.checkRediscoveryHandlerId);
this.logger.info(`Stopped ${this.constructor.name}`);
Expand Down
2 changes: 1 addition & 1 deletion src/nodes/NodeConnection.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ class NodeConnection {
logger: logger.getChild(RPCClient.name),
});
if (validatedNodeId == null) {
never(`connection validated but no valid NodeId was returned`);
never('connection validated but no valid NodeId was returned');
}
// Obtaining remote node ID from certificate chain. It should always exist in the chain if validated.
// This may de different from the NodeId we validated it as if it renewed at some point.
Expand Down
Loading