Change drone state initialisation and notification of plugins #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #247 +/- ##
==========================================
- Coverage 99.39% 99.34% -0.05%
==========================================
Files 54 54
Lines 2144 2145 +1
==========================================
Hits 2131 2131
- Misses 13 14 +1
Continue to review full report at Codecov.
|
giffels
commented
May 11, 2022
| @@ -126,26 +126,24 @@ def test_create_composite( | |||
| @patch("tardis.resources.poolfactory.BatchSystemAgent") | |||
| @patch("tardis.resources.poolfactory.SiteAgent") | |||
| def test_create_drone(self, mock_site_agent, mock_batch_system_agent, mock_drone): | |||
| self.assertEqual( | |||
There was a problem hiding this comment.
This change is not directly related to the reason for the pull request. Instead it fixes a broken unittest. Actually, the test_create_drone test did not test anything.
giffels
requested review from
maxfischer2781,
a team and
RHofsaess
and removed request for
a team
maxfischer2781
requested changes
May 13, 2022
Co-authored-by: Max Fischer <[email protected]>
maxfischer2781
approved these changes
May 13, 2022
This was referenced May 25, 2022
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, newly created drones are initialised with
state=RequestState(). Plugins like theSqliteRegistrywill be notified on the first state changeRequestState->BootingState. As a consequence, theSqliteRegistryis inserting the Drone on the change toBootingState. Sometimes the first startup of a Drone is not successful, which requeues the job associated with the Drone in case of using theHTCondorSiteAdapter. So, the following pattern is occuring in the log.The Drone is in
ResourceState.Runningfor a short moment before it goes toResourceState.Bootingagain due to requeing. So the state of the Drone changes toIntegratingState.Shortly afterwards the drone is
ResourceState.Bootingagain and the Drone changes back toBootingStateagain.This in turn leads to a re-insertion of the Drone in the
SqliteRegistrycausing the following error.sqlite3.IntegrityError: column drone_uuid is not uniqueThis pull request changes the initialisation procedure and the notfication of the plugins, so that the above behaviour is not occuring anymore. A newly created Drone is now initialised with
state = Noneand all plugins are notified first state changeNone->RequestState. The Drone is now inserted when it state changes toRequestStateand all subsequent changes are DB updates.