Disable change of drone_uuid after resource deployment in Moab adapter #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #292 +/- ##
=======================================
Coverage 98.80% 98.80%
=======================================
Files 56 56
Lines 2339 2344 +5
=======================================
+ Hits 2311 2316 +5
Misses 28 28
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
giffels
requested review from
a team,
maxfischer2781 and
eileen-kuehn
and removed request for
a team
giffels
commented
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the Moab site adapter is changing the
drone_uuidafter the resource has been deployed toname-<moab_job_id>. Due to this theSqliteRegistryis not updated anymore (since #247 ), so thatTARDISforgets about deployed resources in case of a restart of the service.This pull requests removes that feature from the Moab adapter and deploys the standard
TardisDroneenvironments variables in the job environment instead, so that the drone can take care of setting the right attributes to the OBS, so thatTARDIScan associate drones to running jobs. In SLURM that is done via aFeature, while on HTCondor it is done via setting aTardisDroneUuidClassAd. Now the almost all site adapters use the very same mechanism.Fixes #291.