Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in ASN1 test dependency #2782

Closed
tmarti2 opened this issue Aug 6, 2019 · 5 comments
Closed

Typo in ASN1 test dependency #2782

tmarti2 opened this issue Aug 6, 2019 · 5 comments
Labels
bug component-crypto Crypto primitives and low-level interfaces

Comments

@tmarti2
Copy link

tmarti2 commented Aug 6, 2019

Hi,
I think I found a typo in the commit 0fbbc64.
Maybe I'm wrong, but I could not find MBEDTLS_ASN1PARSE_C anywhere, while MBEDTLS_ASN1_PARSE_C seems to be used in many files...
Because of this some tests were not enabled (message : "Test suite not enabled" ).
That's it, thanks !
@RonEld RonEld added bug component-crypto Crypto primitives and low-level interfaces labels Aug 11, 2019
@RonEld
Copy link
Contributor

RonEld commented Aug 11, 2019

@tmarti2 Thank you for raising this issue!
This bug in fact needs to be fixed.

@ciarmcom
Copy link

ARM Internal Ref: IOTSSL-2906

@gilles-peskine-arm gilles-peskine-arm mentioned this issue Sep 12, 2019
Open
@gilles-peskine-arm gilles-peskine-arm changed the title Typo in commit 0fbbc64? Typo in ASN1 test dependency Sep 12, 2019
@gilles-peskine-arm
Copy link
Contributor

This was introduced in 2.16 and is part of the crypto library, so it needs to be fixed in Mbed Crypto and in the Mbed TLS 2.16 branch.

AndrzejKurek pushed a commit to AndrzejKurek/mbedtls that referenced this issue Mar 25, 2020
Typo fix in test_suite_asn1write.function
5c15847 
This commit fixes issue Mbed-TLS#2782, spotted by tmarti2.
Signed-off-by: Andrzej Kurek <[email protected]>
@AndrzejKurek AndrzejKurek mentioned this issue Mar 25, 2020
Merged
@AndrzejKurek
Copy link
Contributor

Created a PR for it here: #3124, development was fixed in the meantime.

@tom-cosgrove-arm
Copy link
Contributor

Closing this issue as this is fixed in both development and LTS (2.28)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug component-crypto Crypto primitives and low-level interfaces
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@Patater @ciarmcom @RonEld @gilles-peskine-arm @AndrzejKurek @tmarti2 @tom-cosgrove-arm