Add unit tests for ecp_mod_p192k1() #7424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabor-mezei-arm
added
enhancement
component-crypto
gabor-mezei-arm
added
needs-review
tests/suites/test_suite_ecp.function
Outdated
| size_t limbs = limbs_N; | ||
| size_t bytes = limbs * sizeof(mbedtls_mpi_uint); | ||
|
|
||
| TEST_EQUAL(limbs_X, 2 * limbs); |
There was a problem hiding this comment.
Should that be TEST_LE_U given that the issue requirements are:
Only cases where the input is non-negative and at most twice as long as the modulus.
tests/suites/test_suite_ecp.function
Outdated
| TEST_EQUAL(mbedtls_test_read_mpi(&N, input_N), 0); | ||
| TEST_EQUAL(mbedtls_test_read_mpi(&res, result), 0); | ||
|
|
||
| limbs_X = X.n; |
There was a problem hiding this comment.
If we are using old mpi's I see no reason for intermediate assignments to limbs_X, limbs_N, as they can be directly be acccessed by X.n, N.n
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
gabor-mezei-arm
force-pushed
the
7256_unit_tests_for_p192k1
branch
from
ea8a2ed to
0a11ee6
Compare
|
Rebased |
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
gabor-mezei-arm
added
needs-ci
minosgalanakis
previously approved these changes
Apr 13, 2023
There was a problem hiding this comment.
Looks good ( provided it passes internal CI )
The failure in the OpenCI appears to be caused by other issues
[2023-04-13T12:21:44.102Z] stdout:
[2023-04-13T12:21:44.102Z] stderr: fatal: unable to access 'https://github.com/Mbed-TLS/mbedtls.git/': Failed to connect to github.com port 443: Connection timed out
[2023-04-13T12:21:44.102Z]
[2023-04-13T12:21:44.102Z] at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:2734)
Signed-off-by: Gabor Mezei <[email protected]>
3 tasks
|
Just a reminder: all PRs related to this quarter's bignum work should have the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The task is to add unit tests for ecp_mod_p192k1(). This function reduces the input modulo secp192k1_p.
Resolve #7256
Gatekeeper checklist