ECP: Add Unit Tests for secp224k1 #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minosgalanakis
force-pushed
the
ecp/7257_ecp_mod_p224k1_add_test_cases
branch
from
397b9ce to
761104d
Compare
minosgalanakis
added
needs-review
minosgalanakis
force-pushed
the
ecp/7257_ecp_mod_p224k1_add_test_cases
branch
2 times, most recently
from
d779def to
1229efb
Compare
minosgalanakis
removed
the
needs-preceding-pr
minosgalanakis
force-pushed
the
ecp/7257_ecp_mod_p224k1_add_test_cases
branch
3 times, most recently
from
a18fe9b to
3346e0f
Compare
gabor-mezei-arm
requested changes
Apr 14, 2023
tests/suites/test_suite_ecp.function
Outdated
|
|
||
| TEST_EQUAL(mbedtls_ecp_mod_p224k1(&X), 0); | ||
| TEST_LE_U(mbedtls_mpi_core_bitlen(X.p, X.n), 224); | ||
| mbedtls_mpi_mod_raw_fix_quasi_reduction(X.p, &m); |
There was a problem hiding this comment.
As the description of this issue recommend the mbedtls_mpi_mod_mpi() should be used here.
|
@minosgalanakis this is a deliverable for this quarter, it should have a |
minosgalanakis
force-pushed
the
ecp/7257_ecp_mod_p224k1_add_test_cases
branch
from
3346e0f to
56ca0e3
Compare
minosgalanakis
added
the
needs-preceding-pr
|
I have rebased and addressed the comment. The code is still based on #7424 since it makes resolving conflicts easier and we can test the code as we expect it to come in. Please only review the last three commits When the pr for |
This patch introduces basic unit-testing for the `ecp_mod_p224k1()`. The method is exposed through the ecp_invasive interface, and the standard testing data is being provided by the python framework. Signed-off-by: Minos Galanakis <[email protected]>
This patch introduces a `MBEDTLS_STATIC_TESTABLE` helper method which exposes `ecp_mod_p256k1()` to the test-framework Signed-off-by: Minos Galanakis <[email protected]>
…192k1` Signed-off-by: Minos Galanakis <[email protected]>
minosgalanakis
force-pushed
the
ecp/7257_ecp_mod_p224k1_add_test_cases
branch
from
56ca0e3 to
357b9e1
Compare
minosgalanakis
removed
the
needs-preceding-pr
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #7257
Gatekeeper checklist