Switch from test-ref-configs.pl to separate components #9565
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilles Peskine <[email protected]>
This also suffices for compat.sh. Include the sample programs in this build. They aren't tested by ssl-opt.sh yet, but they soon will be. Signed-off-by: Gilles Peskine <[email protected]>
This also suffices for compat.sh. Include the sample programs in this build. They aren't tested by ssl-opt.sh yet, but they soon will be. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
added
needs-ci
5 tasks
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
Rename the existing component_test_tfm_config which tests a modified version of config-tfm.h for the sake of driver-vs-reference comparison. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
test-ref-configs-go-away
branch
from
12d3469 to
2e449f0
Compare
gilles-peskine-arm
added
needs-review
gilles-peskine-arm
added
priority-high
|
Changing to priority-high after a discussion with Ronald because this is convenient for the repository split: it's one less script to adapt. |
Remove the components migrated from test-ref-configs.pl that use legacy crypto (no enabling of MBEDTLS_USE_PSA_CRYPTO). In the 4.0 preparation branch, we are no longer interested in such configurations. Signed-off-by: Gilles Peskine <[email protected]>
In the components migrated from test-ref-configs.pl, we don't need to activate PSA: it's always on. Also, since there is no "_legacy" component to contrast with, drop "_psa" from the component names. Signed-off-by: Gilles Peskine <[email protected]>
|
In the initial version of this pull request (up to "Remove test-ref-configs.pl, which no longer does anything"), I had made the new components replicate exactly what the Perl script was doing (except for component names). But the script was in fact causing us to do useless work: we were running both legacy and PSA variants of the configurations, but the "legacy" variant actually has |
5 tasks
| set(programs_target "${MBEDTLS_TARGET_PREFIX}programs") | ||
| add_custom_target(${programs_target}) | ||
|
|
||
| set(ssl_opt_target "${MBEDTLS_TARGET_PREFIX}ssl-opt") |
There was a problem hiding this comment.
ssl-opt should also generate tls13-compat.sh which is added by #9563. This can only be done once both parts of the code are in — reminder to make a follow-up PR.
Merged
5 tasks
5 tasks
gilles-peskine-arm
added
approved
Merged
via the queue into
Mbed-TLS:development
with commit Sep 24, 2024
26650f5
4 of 6 checks passed
This was referenced Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-ref-configs.pldoesn't do much. It just has a list of things to build and test. It's poor at reporting: if there's any failure, it just stops. This pull requests moves all the testing of reference configurations to separate components inall.sh.Also,
test-ref-configs.plwas doing the testing twice: once the configuration as given and once with PSA enabled, but in thedevelopmentbranch the configurations all have PSA enabled already. Remove this duplication.This is an alternative to #9564, which improves
test-ref-configs.pl. Differences:ssl-opt.shandcompat.sh.PR checklist