analyze_outcomes.py refactoring: change stringly typed data to classes #9594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gilles-peskine-arm
added
needs-review
5 tasks
|
Sorry I thought I would have time to review this but new things came up so I won't in the next few days. I'm removing myself as a reviewer so that someone else can take it. If nobody did by the end of the week, I might take it again. |
Fix `mypy scripts/xxx.py`, `mypy tests/scripts/xxx.py`, `pylint scripts/xxx.py`, `pylint tests/scripts/xxx.py` failing to find `mbedtls_framework`. Signed-off-by: Gilles Peskine <[email protected]>
Start replacing the stringly typed KNOWN_TASKS by classes for each category of tasks, with a structure that matches the behavior. This commit introduces some transition code. No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
Work on replacing the stringly typed KNOWN_TASKS by classes for each category of tasks, with a structure that matches the behavior. This commit migrates test coverage analysis. No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
Work on the stringly typed KNOWN_TASKS by classes for each category of tasks, with a structure that matches the behavior. This commit migrates the code for driver-vs-reference analysis. To facilitate review, this commit preserves the layout of the data that parametrizes each task. The next commit will migrate the data. No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
Work on the stringly typed KNOWN_TASKS by classes for each category of tasks, with a structure that matches the behavior. This commit migrates the data for driver-vs-reference analysis and gets rid of the transitional code that was using the old form of the data. No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
Signed-off-by: Gilles Peskine <[email protected]>
No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
No intended behavior change. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
analyze_outcomes-classes-development
branch
from
3f609ee to
54cfe77
Compare
|
I've rebased on top of the latest |
paul-elliott-arm
previously approved these changes
Sep 26, 2024
What was formerly called an allow list is now an ignore table. Signed-off-by: Gilles Peskine <[email protected]>
gilles-peskine-arm
force-pushed
the
analyze_outcomes-classes-development
branch
from
0d8b4f1 to
0930b33
Compare
5 tasks
gilles-peskine-arm
removed
the
needs-reviewer
gilles-peskine-arm
added
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring of
analyze_outcomes.pywith no intended behavior change. Preliminary to #9593. The refactoring was needed to be able to use the same ignore functionality for coverage analysis and driver-vs-reference.PR checklist