Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 3.6] Move scripts used by all-core.sh to the framework #9789

Merged
merged 5 commits into from
Dec 10, 2024
Merged

[Backport 3.6] Move scripts used by all-core.sh to the framework #9789

merged 5 commits into from
Dec 10, 2024

Conversation

eleuzi01
Copy link
Contributor

Description

Resolves Mbed-TLS/mbedtls-framework#74

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@eleuzi01 eleuzi01 added enhancement needs-ci Needs to pass CI tests size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Nov 20, 2024
@eleuzi01 eleuzi01 mentioned this pull request Nov 20, 2024
Merged
6 tasks
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review and removed needs-ci Needs to pass CI tests labels Nov 21, 2024
@eleuzi01 eleuzi01 added the needs-ci Needs to pass CI tests label Nov 25, 2024
@eleuzi01 eleuzi01 mentioned this pull request Nov 27, 2024
Merged
@eleuzi01 eleuzi01 removed the needs-ci Needs to pass CI tests label Nov 27, 2024
@eleuzi01 eleuzi01 force-pushed the issue-74-backport branch 2 times, most recently from 57a8db3 to dd34547 Compare December 5, 2024 15:38
mpg
mpg previously approved these changes Dec 6, 2024
View reviewed changes
Copy link
Contributor

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mpg mpg removed the needs-reviewer This PR needs someone to pick it up for review label Dec 9, 2024
@mpg mpg requested a review from valeriosetti December 9, 2024 10:24
valeriosetti
valeriosetti previously approved these changes Dec 9, 2024
View reviewed changes
@eleuzi01 eleuzi01 requested a review from mpg December 9, 2024 10:50
mpg
mpg previously approved these changes Dec 9, 2024
View reviewed changes
@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports needs-ci Needs to pass CI tests and removed needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests labels Dec 9, 2024
@eleuzi01
Move files out of Mbed TLS
9837ad3 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01
Adapt paths for output_env.sh
58172ae 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01
Adapt paths for scripts/quiet
e26f20e 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01
Update submodule
1552e11 
Signed-off-by: Elena Uziunaite <[email protected]>
@eleuzi01 eleuzi01 dismissed stale reviews from mpg and valeriosetti via 1552e11 December 9, 2024 15:38
@eleuzi01 eleuzi01 added needs-review Every commit must be reviewed by at least two team members, and removed approved Design and code approved - may be waiting for CI or backports labels Dec 9, 2024
@eleuzi01 eleuzi01 requested review from valeriosetti and mpg December 9, 2024 15:53
valeriosetti
valeriosetti previously approved these changes Dec 9, 2024
View reviewed changes
@eleuzi01
Update submodule with the merge
383ae2f 
Signed-off-by: Elena Uziunaite <[email protected]>
@mpg mpg added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Dec 10, 2024
@mpg mpg enabled auto-merge December 10, 2024 10:25
@mpg mpg added this pull request to the merge queue Dec 10, 2024
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 189bf03 Dec 10, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpg mpg mpg approved these changes

@valeriosetti valeriosetti valeriosetti approved these changes

Assignees
No one assigned
Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
Roadmap pull requests (new board)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eleuzi01 @mpg @valeriosetti