-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move scripts used by all-core.sh to the framework #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes issues with TEST_CALLOC in GCM buffer overlap tests cases. Signed-off-by: Harry Ramsey <[email protected]>
Exclude the XTS mode because it is not implemented via the PSA API. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
When elements of an exclusive group have dependencies in common turning them off breaks the elements build. Support added to handle and ignore these dependencies when only one of the elements is enabled. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
All cipher padding methods depend on CBC. To aviod switching it off add this dependency to all of the methods and handle it as a common dependency. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
Added `MBEDTLS_CIPHER_MODE_XTS` as a dependency for `PSA_WANT_ALG_XTS`. Otherwise, `MBEDTLS_CIPHER_MODE_XTS` is always enabled which enables a lot of code we would like to be disabled when testing CFB/CTR... only. Signed-off-by: Gabor Mezei <[email protected]>
Signed-off-by: Gabor Mezei <[email protected]>
This commit fixes an issue with check_names failing due to not being defined as a macro in Mbed TLS. This is instead defined by alternative implementations of MBEDTLS_GCM. Signed-off-by: Harry Ramsey <[email protected]>
…cess Signed-off-by: Waleed Elmelegy <[email protected]>
* Used bignum helper API instead of memcpy * changed the key length output to the size of the curve because: - using the bignum produces a bigger size than the curve size due to the limb size being 8 bytes and import key rejects the key if it's not exactly curve size. - we know that the generated key is filled with leading zeros becuase the generated key is bounded by the modulas. * skipped leading zeros when passing the buffer to import_key() due to the intermediate buffer allocated to the maximum size possible and import_key() needs the exact size. Signed-off-by: Waleed Elmelegy <[email protected]>
Add MBEDTLS_ECP_MAX_MPI define to determine the maximum number of bytes for the biggest Elliptic curve in bignum representation. Signed-off-by: Waleed Elmelegy <[email protected]>
MBEDTLS_GCM_ALT has been removed in the current version. Signed-off-by: Harry Ramsey <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Restrict the definition of memcheck/lcov targets to the case where Mbed TLS/TF-PSA-Crypto is the main project. To avoid conflict between the targets when the integration of the TF-PSA-Crypto build system into the Mbed TLS one is completed. Signed-off-by: Ronald Cron <[email protected]>
To avoid conflict between the two targets when the integration of the TF-PSA-Crypto build system into the Mbed TLS one is completed. Signed-off-by: Ronald Cron <[email protected]>
To avoid conflict between the two targets when the integration of the TF-PSA-Crypto cmake build system into the Mbed TLS one is completed. Signed-off-by: Ronald Cron <[email protected]>
Keep installations on MbedTLSTargets export crypto libraries for the sake of mbedtls. Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Signed-off-by: Ronald Cron <[email protected]>
Propagate mbedtls options named differently in TF-PSA-Crypto. Signed-off-by: Ronald Cron <[email protected]>
The empty framework directory is temporary. It will be removed when TF-PSA-Crypto uses its framework submodule. Signed-off-by: Ronald Cron <[email protected]>
Rename mbedcrypto target to tfpsacrypto and prefix all cmake related variables with tfpsacrypto instead of mbedcrypto. Signed-off-by: Ronald Cron <[email protected]>
Do not do the same in the make build system yet, cmake build system only scope for this PR. Signed-off-by: Ronald Cron <[email protected]>
Move copy of crypto libraries to mbedtls as this copy does not make sense in TF-PSA-Crypto context. Also copy all of them, not just tfpsacrypto. Signed-off-by: Ronald Cron <[email protected]>
mpg
approved these changes
Dec 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
…-development Remove obsolete CI Scripts
…pto_config.py Minimal `config.py` for TF-PSA-Crypto
valeriosetti
approved these changes
Dec 9, 2024
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
Signed-off-by: Elena Uziunaite <[email protected]>
valeriosetti
approved these changes
Dec 9, 2024
mpg
approved these changes
Dec 10, 2024
CI is green in both consuming PRs - which both point to the tip of this branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Design and code approved - may be waiting for CI or backports
enhancement
New feature or request
priority-high
High priority - will be reviewed soon
size-s
Estimated task size: small (~2d)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #74
Development PR: Mbed-TLS/mbedtls#9788
3.6 PR: Mbed-TLS/mbedtls#9789