Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "easy" basic checks scripts to the framework #9825

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Dec 5, 2024

Description

Resolves Mbed-TLS/mbedtls-framework#69 on the main repo in development branch

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

@valeriosetti valeriosetti force-pushed the issue69-main branch 2 times, most recently from 4b931dc to d39b542 Compare December 9, 2024 09:09
@eleuzi01 eleuzi01 assigned eleuzi01 and unassigned eleuzi01 Dec 9, 2024
@eleuzi01 eleuzi01 self-requested a review December 9, 2024 13:15
@eleuzi01 eleuzi01 added enhancement needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon labels Dec 9, 2024
@valeriosetti valeriosetti force-pushed the issue69-main branch 7 times, most recently from 881d6d8 to b85285f Compare December 10, 2024 20:18
@eleuzi01
Copy link
Contributor

eleuzi01 commented Dec 11, 2024

There's also a path to assemble_changelog.py in mbedtls/ChangeLog.d/00README.md line 89

@valeriosetti valeriosetti force-pushed the issue69-main branch 3 times, most recently from b9dece1 to 17c103f Compare December 11, 2024 21:12
@@ -86,6 +86,6 @@ See [existing entries](../ChangeLog) for examples.

## How `ChangeLog` is updated

Run [`../scripts/assemble_changelog.py`](../scripts/assemble_changelog.py)
Run [`../framework/scripts/assemble_changelog.py`](../scripts/assemble_changelog.py)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Run [`../framework/scripts/assemble_changelog.py`](../scripts/assemble_changelog.py)
Run [`../framework/scripts/assemble_changelog.py`](../framework/scripts/assemble_changelog.py)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ops, sorry, I definitely overlooked this.

eleuzi01
eleuzi01 previously approved these changes Dec 16, 2024
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm ronald-cron-arm self-requested a review January 7, 2025 09:51
@ronald-cron-arm ronald-cron-arm removed the needs-reviewer This PR needs someone to pick it up for review label Jan 7, 2025
The following files are moved to the framework repo (deleted here):

scripts/assemble_changelog.py
tests/scripts/check-doxy-blocks.pl
tests/scripts/check-python-files.sh
tests/scripts/doxygen.sh
scripts/apidoc_full.sh
tests/scripts/recursion.pl

Signed-off-by: Valerio Setti <[email protected]>
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ronald-cron-arm
ronald-cron-arm previously approved these changes Jan 8, 2025
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

eleuzi01
eleuzi01 previously approved these changes Jan 8, 2025
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Jan 8, 2025
ronald-cron-arm added a commit to Mbed-TLS/mbedtls-framework that referenced this pull request Jan 8, 2025
Move "easy" basic checks scripts to the framework

PR validated by the CI of Mbed-TLS/mbedtls#9825 and Mbed-TLS/mbedtls#9826. The files moved are not used yet in TF-PSA-Crypto thus no impact there. Merging.
Signed-off-by: Valerio Setti <[email protected]>
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronald-cron-arm
Copy link
Contributor

Thanks @eleuzi01 for following up on the review of this PR and the related ones. Setting the auto-merge.

@eleuzi01
Copy link
Contributor

eleuzi01 commented Jan 8, 2025

Thanks @eleuzi01 for following up on the review of this PR and the related ones. Setting the auto-merge.

No problem!

@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Jan 8, 2025
Merged via the queue into Mbed-TLS:development with commit 272ba23 Jan 8, 2025
6 checks passed
@valeriosetti valeriosetti deleted the issue69-main branch January 9, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move "easy" basic checks scripts to the framework
3 participants