Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move "easy" basic checks scripts to the framework #95

Merged
merged 42 commits into from
Jan 8, 2025

Conversation

valeriosetti
Copy link
Contributor

@valeriosetti valeriosetti commented Dec 5, 2024

Resolves #69.

development PR: Mbed-TLS/mbedtls#9825
mbedtls-3.6 PR: Mbed-TLS/mbedtls#9826

Note to self: files were moved using this command:

../mbedtls-docs/tools/bin/mbedtls-move-to-framework \
--from . \
--to ../mbedtls-framework \
--src-branch issue69-main \
--dst-branch issue69-framework \
--path scripts/assemble_changelog.py \
--path tests/scripts/check-doxy-blocks.pl:scripts/check-doxy-blocks.pl \
--path tests/scripts/check-python-files.sh:scripts/check-python-files.sh \
--path tests/scripts/doxygen.sh:scripts/doxygen.sh \
--path scripts/apidoc_full.sh \
--path tests/scripts/recursion.pl:scripts/recursion.pl

NadavTasher and others added 3 commits November 26, 2024 00:51
Improve supply chain security by including a SBOM file with substituted values.

This will be used to construct a composite platform SBOM.

Signed-off-by: Richard Hughes <[email protected]>
This commit removes irrelevant components that are no longer needed in
the 4.0 release.

Signed-off-by: Harry Ramsey <[email protected]>
@eleuzi01 eleuzi01 assigned eleuzi01 and unassigned eleuzi01 Dec 9, 2024
@eleuzi01 eleuzi01 self-requested a review December 9, 2024 13:15
@eleuzi01 eleuzi01 added enhancement New feature or request needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) size-s Estimated task size: small (~2d) and removed size-xs Estimated task size: extra small (a few hours at most) labels Dec 9, 2024
@eleuzi01
Copy link
Contributor

eleuzi01 commented Dec 9, 2024

Looks good, however given this #80 (comment) might need to move files from tests/scripts to just scripts

@valeriosetti valeriosetti force-pushed the issue69-framework branch 2 times, most recently from fb36949 to 8b06ebb Compare December 10, 2024 09:43
This commit fixes a condition where the incorrect submodule error
message was displayed as we were using the CMAKE_CURRENT_SOURCE_DIR
variable instead of MBEDTLS_DIR.

Signed-off-by: Harry Ramsey <[email protected]>
This commit fixes a condition where the incorrect submodule error
message was displayed as the check for the directory returns true only
if the directory does not exist

Signed-off-by: Harry Ramsey <[email protected]>
@valeriosetti valeriosetti force-pushed the issue69-framework branch 2 times, most recently from 279f311 to 0fed0d6 Compare December 10, 2024 15:47
# When the recursion depth might depend on data controlled by the attacker in
# an unbounded way, those functions should use iteration instead.
#
# Typical usage: scripts/recursion.pl library/*.c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be

Suggested change
# Typical usage: scripts/recursion.pl library/*.c
# Typical usage: framework/scripts/recursion.pl library/*.c

now that it's moved?

eleuzi01
eleuzi01 previously approved these changes Dec 16, 2024
Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

MBED_TLS_USE_PSA_CRYPTO is now always enabled we need to remove
documentation discussing cases when it is disabled.

Signed-off-by: Janos Follath <[email protected]>
MBED_TLS_USE_PSA_CRYPTO is now always enabled we need to remove
documentation discussing cases when it is disabled.

Signed-off-by: Janos Follath <[email protected]>
This document is describes the testing strategy for the
`MBEDTLS_USE_PSA_CRYPTO` option. This option is now always on, can't be
disabled and the corresponding behaviour is the only library behaviour.

Signed-off-by: Janos Follath <[email protected]>
MBED_TLS_USE_PSA_CRYPTO is now always enabled we need to remove
documentation discussing cases when it is disabled.

The goal is not to update the document, only to remove
MBED_TLS_USE_PSA_CRYPTO, while making a minimal local context of the
occurrance up to date and sensible.

Signed-off-by: Janos Follath <[email protected]>
eleuzi01 and others added 9 commits December 19, 2024 20:49
Signed-off-by: Elena Uziunaite <[email protected]>
Move check_files.py to the framework
Signed-off-by: Elena Uziunaite <[email protected]>
Undo temporary changes in all-helpers.sh
…doc_9632

Remove discussions of MBEDTLS_USE_PSA_CRYPTO in standalone documentation
Add a SBOM file in CycloneDX format
This commit updates the framework submodule to include commits relevant
to running TF-PSA-Crypto using CMake build system.

Signed-off-by: Harry Ramsey <[email protected]>
This commit updates TF-PSA-Crypto to enable out of source builds by
default.

Signed-off-by: Harry Ramsey <[email protected]>
@ronald-cron-arm
Copy link
Contributor

ronald-cron-arm commented Jan 7, 2025

The mbedtls PRs have a framework conflict now. You probably need to rebase this one against the head of mbedtls-framework:main and update the mbedtls PRs accordingly.

Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise as already mentioned you probably need to rebase on top of main head.

Added debug print in tls13 ssl_tls13_write_key_share_ext
valeriosetti and others added 4 commits January 8, 2025 09:51
The following files are added (imported) from the main Mbed TLS repo:

scripts/assemble_changelog.py
scripts/check-doxy-blocks.pl
scripts/check-python-files.sh
scripts/doxygen.sh
scripts/apidoc_full.sh
scripts/recursion.pl

Signed-off-by: Valerio Setti <[email protected]>
Copy link
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

Copy link
Contributor

@eleuzi01 eleuzi01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@eleuzi01 eleuzi01 added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, needs-reviewer This PR needs someone to pick it up for review labels Jan 8, 2025
@ronald-cron-arm ronald-cron-arm merged commit 3262864 into Mbed-TLS:main Jan 8, 2025
1 of 2 checks passed
@valeriosetti valeriosetti deleted the issue69-framework branch January 9, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Design and code approved - may be waiting for CI or backports enhancement New feature or request priority-high High priority - will be reviewed soon size-s Estimated task size: small (~2d)
Development

Successfully merging this pull request may close these issues.

Move "easy" basic checks scripts to the framework