Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mixpanel migration #37

Merged
merged 10 commits into from
Jun 2, 2020
Merged

Mixpanel migration #37

merged 10 commits into from
Jun 2, 2020

Conversation

estebanmino
Copy link
Contributor

This PR

  • Initialize mixpanel only if __mmMixpanelToken is present on window
  • Receives mixpanel token project from window through __mmMixpanelToken so we can pass mobile token or extension token if it's needed at some point
  • Identifies the user with the use of __mmDistinctId on mixpanel
  • Updates event names

Related MetaMask/metamask-mobile#1560

andrepimenta
andrepimenta approved these changes Jun 2, 2020
View reviewed changes
Copy link
Member

@andrepimenta andrepimenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@estebanmino estebanmino merged commit 6fb48de into MetaMask:master Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrepimenta andrepimenta andrepimenta approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estebanmino @andrepimenta