Mixpanel migration #1560
Merged
Mixpanel migration #1560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this one requires QA, I'd say regression tests should suffice |
ibrahimtaveras00
added
the
No QA Needed
|
@ibrahimtaveras00 could you QA current develop with https://festive-bohr-22f491.netlify.app/ ? that's the new home dapp we'll have after we release |
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* bridge * bridge * correct native implementation and pass args to homepage * people identify * rm dep * doc * _peopleIdentify Co-authored-by: Ibrahim Taveras <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the way the app interacts with home dapps site, now we send mixpanel token from the app to the site as well as distinct id to have tracking of what's happening on that site.
Checklist
Issue
Resolves #???