Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.0 #191

Merged
merged 6 commits into from
Jun 16, 2023
Merged

v1.0.0 #191

merged 6 commits into from
Jun 16, 2023

Conversation

bergarces
Copy link
Contributor

Changed

  • BREAKING: Separate the bridge from the keyring (#156)
    • The Ledger bridge is now a separate class (LedgerIframeBridge), which must be constructed separately from the keyring and passed in as a constructor argument.
    • The bridge initialization has been moved from the keyring constructor to the keyring init method. The bridge is expected to be passed to the keyring uninitialized, and the keyring init method is expected to be called after keyring construction (before the keyring is used).
    • The keyring constructor no longer accepts keyring state. Instead, any pre-existing keyring state should be passed to the deserialize method after construction.
  • BREAKING: Export changed from default to named (#174)
    • The keyring is exported as LedgerKeyring
  • Add TypeScript types (#174)

@bergarces bergarces requested a review from a team as a code owner June 16, 2023 12:45
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@bergarces bergarces mentioned this pull request Jun 16, 2023
@bergarces bergarces merged commit d8269ce into main Jun 16, 2023
@bergarces bergarces deleted the release/1.0.0 branch June 16, 2023 12:53
Gudahtt added a commit that referenced this pull request Jun 16, 2023
This reverts commit d8269ce.
@Gudahtt Gudahtt mentioned this pull request Jun 16, 2023
Gudahtt added a commit that referenced this pull request Jun 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants