v0.16.0 #189
Closed
v0.16.0 #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bergarces
force-pushed
the
release/0.16.0
branch
2 times, most recently
from
136c6bf to
7a44cf5
Compare
bergarces
force-pushed
the
release/0.16.0
branch
from
7a44cf5 to
f8e5846
Compare
Gudahtt
reviewed
Jun 15, 2023
Gudahtt
reviewed
Jun 15, 2023
CHANGELOG.md
Outdated
| ## [0.16.0] | ||
| ### Changed | ||
| - **BREAKING:** Refactor code to split keyring from bridge logic. ([#156](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/156)) | ||
| - Migrate code to TypeScript. ([#174](https://github.com/MetaMask/eth-ledger-bridge-keyring/pull/174)) |
There was a problem hiding this comment.
This should probably be two entries: one for the added types (non-breaking), and one for the change from default export to named export (breaking).
Anything else worth noting here @mikesposito ?
Gudahtt
reviewed
Jun 16, 2023
Gudahtt
reviewed
Jun 16, 2023
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@metamask/eth-ledger-bridge-keyring", | |||
| "version": "0.15.0", | |||
| "version": "0.16.0", | |||
There was a problem hiding this comment.
Thoughts on making this v1 instead? @gantunesr and I are in agreement that it seems appropriate
There was a problem hiding this comment.
I've bumped the version, but I cannot change the branch name.
I've created a new PR with the correct branch name and all the changes discussed: #191
bergarces
force-pushed
the
release/0.16.0
branch
from
c230a6a to
117719f
Compare
|
Superceded by #191 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed