Skip to content

Commit

Permalink
Fix normalize for empty strings (#315)
Browse files Browse the repository at this point in the history
* fix: normalize should also work with empty strings

* test: add test for empty string normalization
  • Loading branch information
mikesposito authored Jun 26, 2023
1 parent fb40290 commit 89035e2
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
6 changes: 6 additions & 0 deletions src/utils.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -124,6 +124,12 @@ describe('normalize', function () {
expect(result).toBe('0x');
});

it('should normalize an empty string to 0x', function () {
const initial = '';
const result = normalize(initial);
expect(result).toBe('0x');
});

// TODO: Add validation to disallow null.
it('should return undefined if given null', function () {
const initial = null;
Expand Down
2 changes: 1 addition & 1 deletion src/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ export function recoverPublicKey(
* @returns The normalized value.
*/
export function normalize(input: number | string): string | undefined {
if (!input) {
if (isNullish(input)) {
return undefined;
}

Expand Down

0 comments on commit 89035e2

Please sign in to comment.