Update onboarding library docs with new name + valid HTML #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked by MetaMask/metamask-onboarding#33 |
rekmarks
approved these changes
Jul 2, 2020
Gudahtt
approved these changes
Jul 2, 2020
| @@ -126,25 +126,24 @@ Doing this step will give you editor auto-completion for the methods exposed by | |||
| ### Using Vanilla Javascript + HTML | |||
|
|
|||
| ```html | |||
| <html> | |||
| <!DOCTYPE html> | |||
| <html lang="en-CA"> | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs MetaMask/metamask-onboarding#30 and MetaMask/metamask-onboarding#32
This PR updates the onboarding library docs with the new v1 name and tidies the example markup.