Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example in README with validated HTML #30

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

whymarrh
Copy link
Contributor

This change updates the HTML in the example in the README to have no errors or warnings, as defined by the W3C's HTML Checker.

This change updates the HTML in the example in the README to have no errors or warnings, as defined by [the W3C's HTML Checker](https://validator.w3.org/nu/about.html).
@whymarrh whymarrh marked this pull request as ready for review June 25, 2020 14:44
@whymarrh whymarrh requested a review from a team as a code owner June 25, 2020 14:44
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

First I've heard that it's recommended to omit type="text/javascript". TIL

@whymarrh whymarrh merged commit 45ca26f into master Jun 25, 2020
@whymarrh whymarrh deleted the valid-html branch June 25, 2020 14:56
@brad-decker
Copy link
Contributor

@whymarrh i duplicated this example in the metamask docs for the onboarding library, I'll carry over your changes in a new PR.

@whymarrh
Copy link
Contributor Author

Ah, we could probably remove it from here and link to the docs website then!

@whymarrh
Copy link
Contributor Author

@brad-decker I've started a PR MetaMask/metamask-docs#125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants