Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ENS resolution on any EVM compatible chain (including L2s) #18648

Closed
bschorchit opened this issue Apr 18, 2023 · 2 comments · Fixed by #26242
Closed

Support ENS resolution on any EVM compatible chain (including L2s) #18648

bschorchit opened this issue Apr 18, 2023 · 2 comments · Fixed by #26242
Assignees
Labels
area-transactions release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations-planning (only for internal use within Confirmations team) team-identity type-enhancement

Comments

@bschorchit
Copy link

bschorchit commented Apr 18, 2023

Background

Currently ENS resolution is only supported on Ethereum mainnet. This issue addresses extending support for it for any EVM network supported by ENS.

Acceptance Criterias

  1. User facing functionality for ENS resolution that currently exists for Ethereum Mainnet is replicated for all ENS-supported EVM compatible chains in MM
  2. When a network doesn't have ENS support, the Network does not support ENS warning is shown when the user tries to input an ENS name on a send flow
  3. We should test this with Linea test network (once it has ENS support) and confirm it's working

Repro Steps

  1. Click on Send
  2. Input an ENS address such as Vitalik.eth
  3. See ENS resolved to the correct registered address if you're on Ethereum Mainnet, Goerli or Sepolia or see the Network does not support ENS warning if you're on a different network

References

@mozrt2
Copy link

mozrt2 commented Dec 14, 2023

Hi @bschorchit - I wanted to ask if there are any updates on this issue? It seems like a widely requested one (see for example 12990) and important for good L2 UX

@mirceanis
Copy link
Contributor

This will be resolved by #26242

@mirceanis mirceanis self-assigned this Sep 18, 2024
@metamaskbot metamaskbot added the release-12.5.0 Issue or pull request that will be included in release 12.5.0 label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-transactions release-12.5.0 Issue or pull request that will be included in release 12.5.0 team-confirmations-planning (only for internal use within Confirmations team) team-identity type-enhancement
Projects
None yet
4 participants