[Bug]: Show ENS domain in address bar toggle defaults

[PeterYinusa]

Describe the bug

The Show ENS domain in address bar toggle should switch OFF if the IPFS gateway is switched OFF, as the functionality does not work without an IPFS gateway

ens.domains.and.ipfs.mov

Steps to reproduce

1. Log in to the extension
2. Click the Account menu, followed by the Settings menu item
3. Click Settings & Privacy from the left-hand menu
4. Turn ON the IPFS gateway toggle
5. Turn ON the Show ENS domain in address bar toggle
6. navigate to https://metamask.eth/ in another tab
7. switch back to the extension
8. Turn OFF the IPFS gateway toggle, Leave Show ENS domain in address bar toggle ON
9. navigate to https://metamask.eth/ in another tab

Error messages or log output

No response

Version

11.1.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

[gauthierpetetin]

Hi @PeterYinusa ,

The Show ENS domain in address bar toggle should switch OFF if the IPFS gateway is switched OFF, as the functionality does not work without an IPFS gateway

I'm not sure about this assumption, my understanding is:

1. In some cases, an ENS resolves to an IPFS website. Ex: https://vitalik.eth/ => https://bafybeidj4gxdnaau7xzt52nxxrla7oyu75shok3xngyu6buww4zu6zvhmu.ipfs.dweb.link/
2. In some cases, an ENS resolves to a website that's not on IPFS. Ex: https://metamask.eth/ => https://app.ens.domains/metamask.eth

If that's correct, it means the Show ENS domain in address bar toggle doesn't have to switch OFF if the IPFS gateway is switched OFF.

It's worth being investigated though.

[legobeat]

Yes, ENS resolution and integration shouldn't depend on IPFS connectivity being available. If it does today in some way, that sounds like a separate issue worth investigating.

https://docs.ens.domains/dapp-developer-guide/resolving-names#looking-up-other-resources

E.g. if MetaMask Extension is used Tor Browser and navigates to example.eth resolving to example.onion, I assume the intention is that example.eth should still be displayed in the address bar and shouldn't require IPFS?

[legobeat]

Related:

• Support ENS resolution on any EVM compatible chain (including L2s) #18648
• Support for ENS Multicoin when connected to other EVM chain specifications#11
• Ens multicoin #18035

[PeterYinusa]

@gauthierpetetin My assumption is that most will be static website content hosted on IPFS.
Thanks for providing more info, as I now see that my assumption was incorrect.
However, both https://vitalik.eth/ (IPFS) and https://metamask.eth/ (not IPFS) do not resolve with IPFS gateway OFF and Show ENS domains in address bar ON. They only resolve when both the above settings are ON.

Hi @PeterYinusa ,

The Show ENS domain in address bar toggle should switch OFF if the IPFS gateway is switched OFF, as the functionality does not work without an IPFS gateway

I'm not sure about this assumption, my understanding is:

1. In some cases, an ENS resolves to an IPFS website. Ex: https://vitalik.eth/ => https://bafybeidj4gxdnaau7xzt52nxxrla7oyu75shok3xngyu6buww4zu6zvhmu.ipfs.dweb.link/
2. In some cases, an ENS resolves to a website that's not on IPFS. Ex: https://metamask.eth/ => https://app.ens.domains/metamask.eth

If that's correct, it means the Show ENS domain in address bar toggle doesn't have to switch OFF if the IPFS gateway is switched OFF.

It's worth being investigated though.

[PeterYinusa]

I've placed the DO NOT MERGE label on #20915 so we can continue the discussion on this issue.

[gauthierpetetin]

@PeterYinusa , indeed what you outline is unexpected behaviour.
Expected behaviour is the following:

• When Show ENS domain in address bar toggle is ON and IPFS gateway is ON => All should resolve
• When Show ENS domain in address bar toggle is ON and IPFS gateway is OFF => https://metamask.eth/ (not IPFS) should resolve and https://vitalik.eth/ (IPFS) should not resolve
• When Show ENS domain in address bar toggle is OFF and IPFS gateway is ON => https://metamask.eth/ (not IPFS) should not resolve and https://vitalik.eth/ (IPFS) should resolve
• When Show ENS domain in address bar toggle is OFF and IPFS gateway is OFF => None should resolve

@tommasini do you confirm that's aligned with what we have on Mobile.

[tommasini]

Yes! That's what we have almost finished on mobile 🙏🏼