Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for ENS Multicoin when connected to other EVM chain #11

Closed
makoto opened this issue Mar 9, 2023 · 1 comment · Fixed by MetaMask/metamask-extension#26242
Closed

Comments

@makoto
Copy link

makoto commented Mar 9, 2023

Currently, the ENS name is resolvable only when Metamask is connected to Ethereum Mainnet.

However, ENS has support for multicoin types (eg: Bitcoin) since 2019 and we recently extended to support any EVM chains.

The proposed flow is.

  1. If it's currently connected to ChainId 1, get the address record with coinType 60 (ETH) (eg: resolver.getAddr(namehash, 60)
  2. If not connected to ChainId1, then resolve against Mainnet but with the equivalent coinType.

For example, the coinType of Polgyon (ChainID 137) is 2147483785 hence resolver.getAddr(namehash, 2147483785)

The draft implementation is at MetaMask/metamask-extension#18035 and I would like to get feedback before turning this into production-ready PR.

@mirceanis
Copy link

mirceanis commented Sep 18, 2024

This is fixed in the extension by MetaMask/metamask-extension#26242

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants