Fix "Text strings must be rendered within a <Text> component" (#2193)

* Fix issue #2179 * Increase lineHeight on errors * Fix props
MetaMask · Feb 2, 2021 · f130af8 · f130af8
1 parent 45b9717
commit f130af8
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 2 deletions.
diff --git a/app/components/UI/ApproveTransactionReview/index.js b/app/components/UI/ApproveTransactionReview/index.js
@@ -203,6 +203,7 @@ const styles = StyleSheet.create({
 	error: {
 		color: colors.red,
 		fontSize: 12,
+		lineHeight: 16,
 		...fontStyles.normal,
 		textAlign: 'center'
 	},

diff --git a/app/components/UI/TransactionReview/TransactionReviewFeeCard/index.js b/app/components/UI/TransactionReview/TransactionReviewFeeCard/index.js
@@ -39,7 +39,7 @@ class TransactionReviewFeeCard extends PureComponent {
 		/**
 		 * Total transaction value in fiat
 		 */
-		totalFiat: PropTypes.object,
+		totalFiat: PropTypes.oneOfType([PropTypes.arrayOf(PropTypes.node), PropTypes.node, PropTypes.string]),
 		/**
 		 * Transaction value in fiat before gas fee
 		 */
@@ -142,7 +142,7 @@ class TransactionReviewFeeCard extends PureComponent {
 					{!!totalFiat && this.renderIfGasEstimationReady(totalAmount)}
 				</Summary.Row>
 				<Summary.Row end last>
-					{this.renderIfGasEstimationReady(equivalentTotalAmount)}
+					{this.renderIfGasEstimationReady(<Text bold>{equivalentTotalAmount}</Text>)}
 				</Summary.Row>
 			</Summary>
 		);

diff --git a/app/components/UI/TransactionReview/TransactionReviewInformation/index.js b/app/components/UI/TransactionReview/TransactionReviewInformation/index.js
@@ -106,6 +106,7 @@ const styles = StyleSheet.create({
 	error: {
 		color: colors.red,
 		fontSize: 12,
+		lineHeight: 16,
 		...fontStyles.normal,
 		textAlign: 'center'
 	},

diff --git a/app/components/Views/SendFlow/Confirm/index.js b/app/components/Views/SendFlow/Confirm/index.js
@@ -203,6 +203,7 @@ const styles = StyleSheet.create({
 	error: {
 		color: colors.red,
 		fontSize: 12,
+		lineHeight: 16,
 		...fontStyles.normal,
 		textAlign: 'center'
 	},