Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "Text strings must be rendered within a <Text> component" #2193

Merged
merged 3 commits into from
Feb 2, 2021
Merged

Fix "Text strings must be rendered within a <Text> component" #2193

merged 3 commits into from
Feb 2, 2021

Conversation

rickycodes
Copy link
Contributor

@rickycodes rickycodes commented Jan 30, 2021 •
edited
Loading

There's an error when you try to do token transfer in a dapp

Before:

image

After:

image

Notes:

I actually broke this in https://github.com/MetaMask/metamask-mobile/pull/2076/files#diff-3b63689d21af01cd00a2246b982b5d0c8471f65049cd3693179c90bc05d4418cR145

I have to check a couple of other things out, it's odd that the usd is lower case here.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2179

@rickycodes rickycodes requested a review from a team as a code owner January 30, 2021 05:38
@rickycodes rickycodes added needs-qa Any New Features that needs a full manual QA prior to being added to a release. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 30, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Feb 1, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Feb 1, 2021
@rickycodes rickycodes merged commit 70568de into develop Feb 2, 2021
@rickycodes rickycodes deleted the bugfix/issue-2179 branch February 2, 2021 01:35
rickycodes added a commit that referenced this pull request Feb 25, 2021
@rickycodes
Merge branch 'develop' into storage-migration-update
2c390bc 
* develop: (48 commits)
  Fix input state (#2265)
  bump android versionCode (#2260)
  bugfix/use bignumber for transfer deeplinks (#2257)
  Fix account list scroll (#2256)
  TransactionController from controllers (#2243)
  Fix circleci apk (#2240)
  v1.0.11 (#2238)
  Feature/warn when replacing (#2176)
  contract metadata images bump (#2233)
  Handle `balanceError` case (#2148)
  Remove best deals badge from WYRE transfers. (#2228)
  @metamask/[email protected] (#2217)
  Fix cloudflare redirects (#2180)
  Merge pull request from GHSA-wmvx-96jh-gcr4
  Update @metamask/contract-metadata (#2203)
  React Native update to 0.63 (#2078)
  Create dependabot.yml (#2204)
  Fix "Text strings must be rendered within a <Text> component" (#2193)
  Use navigate instead of push (#2191)
  Add fiat on ramp modal close button extra hit area (#2174)
  ...
rickycodes added a commit that referenced this pull request Jan 31, 2022
@rickycodes
Fix "Text strings must be rendered within a <Text> component" (#2193)
f130af8 
* Fix issue #2179

* Increase lineHeight on errors

* Fix props
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

View: Root Error: Text strings must be rendered within a <Text> component
3 participants
@rickycodes @estebanmino @ibrahimtaveras00