feat: Enable feature Flag Values with Scope Based on "threshold" in mobile #12627

joaoloureirop · 2024-12-10T16:28:38Z

Description

Related issues

Fixes: https://github.com/MetaMask/mobile-planning/issues/2065

Manual testing steps

Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-12-10T16:28:52Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

socket-security · 2024-12-10T16:30:45Z

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package	New capabilities	Transitives	Size	Publisher
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`+1`	471 kB	metamaskbot
npm/@metamask/[email protected] 🔁 npm/@metamask/[email protected]	None	`0`	148 kB	metamaskbot

View full report↗︎

joaoloureirop · 2024-12-11T17:30:17Z

metro.config.js

+const path = require("path");
+
+const featureFlagModuleDir = path.resolve(__dirname, "../../core/feature-flags/packages/remote-feature-flag-controller");
+
+const extraNodeModules = {
+  "@metamask/remote-feature-flag-controller": featureFlagModuleDir,
+};
+
+const watchFolders = [
+  featureFlagModuleDir,
+];
+
 module.exports = function (baseConfig) {
  const defaultConfig = mergeConfig(baseConfig, getDefaultConfig(__dirname));
  const {
    resolver: { assetExts, sourceExts },
  } = defaultConfig;

  return mergeConfig(defaultConfig, {
+    watchFolders,
    resolver: {
      assetExts: assetExts.filter((ext) => ext !== 'svg'),
      sourceExts: [...sourceExts, 'svg', 'cjs', 'mjs'],
      resolverMainFields: ['sbmodern', 'react-native', 'browser', 'main'],
+      extraNodeModules: new Proxy (extraNodeModules, {
+        get: (target, name) =>
+          name in target ? target[name] : path.join(process.cwd(), `node_modules/${name}`),
+      }),
+      unstable_enableSymlinks: true,


to be reverted once controller update has been published

metro.transform.js

joaoloureirop · 2024-12-11T17:31:49Z

package.json

@@ -188,7 +188,7 @@
    "@metamask/react-native-payments": "^2.0.0",
    "@metamask/react-native-search-api": "1.0.1",
    "@metamask/react-native-webview": "^14.0.4",
-    "@metamask/remote-feature-flag-controller": "^1.0.0",
+    "@metamask/remote-feature-flag-controller": "link:../../core/feature-flags/packages/remote-feature-flag-controller",


to be reverted once controller update has been published

app/core/Engine/Engine.ts

app/core/Engine/controllers/RemoteFeatureFlagController/utils.ts

joaoloureirop · 2024-12-12T16:17:18Z

@NicolasMassart The motivation to pass the metametrics id Promise rather than the actual value is to avoid adding another argument into the Engine constructor and to avoid turning functions that call Engine.init into async ones.

We can't await for a Promise inside a class constructor.

NicolasMassart

Looks good to me.

joaoloureirop · 2024-12-12T16:20:05Z

Waiting on RemoteFeatureFlagController update npm publish

NicolasMassart · 2025-01-10T14:30:34Z

Could we split the work on this PR and extract the metametrics changes to its own PR as it would fix #12469 and #12913 ?

joaoloureirop · 2025-01-10T16:41:43Z

Could we split the work on this PR and extract the metametrics changes to its own PR as it would fix #12469 and #12913 ?

Ah yes, all the experimental work done here while in draft mode will be either moved to a different PR or completely dropped.

github-actions · 2025-01-15T10:30:19Z

Bitrise

❌❌❌ pr_smoke_e2e_pipeline failed on Bitrise! ❌❌❌

Commit hash: 3b9aecf
Build link: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e84982af-de12-4825-929e-6edd844f1ef3

Note

You can kick off another pr_smoke_e2e_pipeline on Bitrise by removing and re-applying the Run Smoke E2E label on the pull request

Tip

Check the documentation if you have any doubts on how to understand the failure on bitrise

sonarqubecloud · 2025-01-15T18:26:33Z

Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 60%)

See analysis details on SonarQube Cloud

metamaskbot added the team-mobile-platform label Dec 10, 2024

joaoloureirop added 4 commits December 10, 2024 17:43

metro bundler: use local module

a76dd4c

dev env: ignore ts errors

d25ef6e

engine: fetch metametrics id before engine init

877699c

feature flag controller: use metaMetricsId

7ffa266

joaoloureirop force-pushed the feat/feature-flag-threshold branch from 0a4fd9f to 7ffa266 Compare December 11, 2024 17:24

joaoloureirop commented Dec 11, 2024

View reviewed changes

metro.transform.js Show resolved Hide resolved

joaoloureirop commented Dec 11, 2024

View reviewed changes

use promise to get metametrics id

8769485

joaoloureirop marked this pull request as ready for review December 12, 2024 13:25

joaoloureirop requested review from a team as code owners December 12, 2024 13:25

NicolasMassart reviewed Dec 12, 2024

View reviewed changes

app/core/Engine/Engine.ts Outdated Show resolved Hide resolved

app/core/Engine/Engine.ts Outdated Show resolved Hide resolved

app/core/Engine/controllers/RemoteFeatureFlagController/utils.ts Show resolved Hide resolved

remove dev code

d0e7eb9

NicolasMassart previously approved these changes Dec 12, 2024

View reviewed changes

getMetaMetricsId as a sync function

6406624

joaoloureirop dismissed NicolasMassart’s stale review via 6406624 January 8, 2025 13:50

Merge branch 'main' into feat/feature-flag-threshold

9f285b5

joaoloureirop marked this pull request as draft January 9, 2025 10:07

joaoloureirop mentioned this pull request Jan 9, 2025

refactor: make storage-wrapper operations synchronous #12913

Open

9 tasks

joaoloureirop force-pushed the feat/feature-flag-threshold branch 3 times, most recently from e8ea298 to d755986 Compare January 15, 2025 10:19

joaoloureirop added 2 commits January 15, 2025 10:21

add metametricsid to redux

e93b201

bump @metamask/remote-feature-flag-controller

9aa427d

joaoloureirop force-pushed the feat/feature-flag-threshold branch from d755986 to 9aa427d Compare January 15, 2025 10:22

joaoloureirop added 3 commits January 15, 2025 10:24

Merge branch 'main' into feat/feature-flag-threshold

edc0a1e

revert indents

d44068e

Merge branch 'main' into feat/feature-flag-threshold

3b9aecf

joaoloureirop marked this pull request as ready for review January 15, 2025 10:29

joaoloureirop added the Run Smoke E2E Triggers smoke e2e on Bitrise label Jan 15, 2025

joaoloureirop added 5 commits January 15, 2025 11:05

dedupe

dee7b47

fix feature flag controller unit tests

a77adcf

fix linter & sagas tests

a81f019

fix typo

e6324fd

snapshot

00af125

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Enable feature Flag Values with Scope Based on "threshold" in mobile #12627

feat: Enable feature Flag Values with Scope Based on "threshold" in mobile #12627

joaoloureirop commented Dec 10, 2024

github-actions bot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 •

edited

Loading

joaoloureirop Dec 11, 2024

joaoloureirop Dec 11, 2024

joaoloureirop commented Dec 12, 2024

NicolasMassart left a comment

joaoloureirop commented Dec 12, 2024 •

edited

Loading

NicolasMassart commented Jan 10, 2025

joaoloureirop commented Jan 10, 2025

github-actions bot commented Jan 15, 2025 •

edited by metamaskbot

Loading

sonarqubecloud bot commented Jan 15, 2025

feat: Enable feature Flag Values with Scope Based on "threshold" in mobile #12627

Are you sure you want to change the base?

feat: Enable feature Flag Values with Scope Based on "threshold" in mobile #12627

Conversation

joaoloureirop commented Dec 10, 2024

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Dec 10, 2024

socket-security bot commented Dec 10, 2024 • edited Loading

joaoloureirop Dec 11, 2024

Choose a reason for hiding this comment

joaoloureirop Dec 11, 2024

Choose a reason for hiding this comment

joaoloureirop commented Dec 12, 2024

NicolasMassart left a comment

Choose a reason for hiding this comment

joaoloureirop commented Dec 12, 2024 • edited Loading

NicolasMassart commented Jan 10, 2025

joaoloureirop commented Jan 10, 2025

github-actions bot commented Jan 15, 2025 • edited by metamaskbot Loading

Bitrise

sonarqubecloud bot commented Jan 15, 2025

Quality Gate failed

socket-security bot commented Dec 10, 2024 •

edited

Loading

joaoloureirop commented Dec 12, 2024 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited by metamaskbot

Loading