feat: Enable feature Flag Values with Scope Based on "threshold"

app/core/Engine/Engine.ts

@@ -274,6 +274,7 @@ export class Engine {
   // eslint-disable-next-line @typescript-eslint/default-param-last
   constructor(
     initialState: Partial<EngineState> = {},
+    metaMetricsId: string | undefined,
     initialKeyringState?: KeyringControllerState | null,
   ) {
     this.controllerMessenger = new ExtendedControllerMessenger();
@@ -510,8 +511,10 @@ export class Engine {
         allowedEvents: [],
       }),
       disabled: !isBasicFunctionalityToggleEnabled(),
+      metaMetricsId,
     });
 
+    console.log('controller', remoteFeatureFlagController);
     const phishingController = new PhishingController({
       messenger: this.controllerMessenger.getRestricted({
         name: 'PhishingController',
@@ -2156,8 +2159,8 @@ export default {
     instance = null;
   },
 
-  init(state: Partial<EngineState> | undefined, keyringState = null) {
-    instance = Engine.instance || new Engine(state, keyringState);
+  init(state: Partial<EngineState> | undefined, keyringState = null, metaMetricsId: string | undefined) {
+    instance = Engine.instance || new Engine(state, metaMetricsId, keyringState);
     Object.freeze(instance);
     return instance;
   },

app/core/Engine/controllers/RemoteFeatureFlagController/types.ts

@@ -2,7 +2,8 @@ import { RemoteFeatureFlagControllerMessenger, RemoteFeatureFlagControllerState
 
 export interface RemoteFeatureFlagInitParamTypes {
   state?: RemoteFeatureFlagControllerState;
-  messenger: RemoteFeatureFlagControllerMessenger,
-  disabled: boolean
+  messenger: RemoteFeatureFlagControllerMessenger;
+  disabled: boolean;
+  metaMetricsId: string | undefined;
 }
 

app/core/Engine/controllers/RemoteFeatureFlagController/utils.ts

@@ -33,12 +33,14 @@ export const createRemoteFeatureFlagController = ({
   state,
   messenger,
   disabled,
+  metaMetricsId,
 }: RemoteFeatureFlagInitParamTypes) => {
 
   const remoteFeatureFlagController = new RemoteFeatureFlagController({
     messenger,
     state,
     disabled,
+    metaMetricsId,
     clientConfigApiService: new ClientConfigApiService({
       fetch,
       config: {

metro.config.js

@@ -9,17 +9,35 @@
 const { getDefaultConfig } = require('expo/metro-config');
 const { mergeConfig } = require('@react-native/metro-config');
 
+const path = require("path");
+
+const featureFlagModuleDir = path.resolve(__dirname, "../../core/feature-flags/packages/remote-feature-flag-controller");
+
+const extraNodeModules = {
+  "@metamask/remote-feature-flag-controller": featureFlagModuleDir,
+};
+
+const watchFolders = [
+  featureFlagModuleDir,
+];
+
 module.exports = function (baseConfig) {
   const defaultConfig = mergeConfig(baseConfig, getDefaultConfig(__dirname));
   const {
     resolver: { assetExts, sourceExts },
   } = defaultConfig;
 
   return mergeConfig(defaultConfig, {
+    watchFolders,
     resolver: {
       assetExts: assetExts.filter((ext) => ext !== 'svg'),
       sourceExts: [...sourceExts, 'svg', 'cjs', 'mjs'],
       resolverMainFields: ['sbmodern', 'react-native', 'browser', 'main'],
+      extraNodeModules: new Proxy (extraNodeModules, {
+        get: (target, name) =>
+          name in target ? target[name] : path.join(process.cwd(), `node_modules/${name}`),
+      }),
+      unstable_enableSymlinks: true,
     },
     transformer: {
       babelTransformerPath: require.resolve('./metro.transform.js'),

metro.transform.js

@@ -70,9 +70,6 @@ module.exports.transform = async ({ src, filename, options }) => {
       active: getBuildTypeFeatures(),
     });
 
-    if (didModify) {
-      await lintTransformedFile(getESLintInstance(), filename, processedSource);
-    }
     return defaultTransformer.transform({
       src: processedSource,
       filename,

package.json

@@ -188,7 +188,7 @@
     "@metamask/react-native-payments": "^2.0.0",
     "@metamask/react-native-search-api": "1.0.1",
     "@metamask/react-native-webview": "^14.0.4",
-    "@metamask/remote-feature-flag-controller": "^1.0.0",
+    "@metamask/remote-feature-flag-controller": "link:../../core/feature-flags/packages/remote-feature-flag-controller",
     "@metamask/rpc-errors": "^7.0.1",
     "@metamask/scure-bip39": "^2.1.0",
     "@metamask/sdk-communication-layer": "0.29.0-wallet",

yarn.lock

@@ -5191,14 +5191,9 @@
     escape-string-regexp "^4.0.0"
     invariant "2.2.4"
 
-"@metamask/remote-feature-flag-controller@^1.0.0":
-  version "1.0.0"
-  resolved "https://registry.yarnpkg.com/@metamask/remote-feature-flag-controller/-/remote-feature-flag-controller-1.0.0.tgz#048162eaa6fa34401cfbabfa0eb33f0255bb2945"
-  integrity sha512-jrjEQhW/RdHQ/GQbgXH97N6YqDUW7nGA40lEr0TUSIhJVVaHDX0gCiNmJZcQ89yLY4DZ0bisEwjrCu8LycYiQQ==
-  dependencies:
-    "@metamask/base-controller" "^7.0.2"
-    "@metamask/utils" "^10.0.0"
-    cockatiel "^3.1.2"
+"@metamask/remote-feature-flag-controller@link:../../core/feature-flags/packages/remote-feature-flag-controller":
+  version "0.0.0"
+  uid ""
 
 "@metamask/[email protected]", "@metamask/rpc-errors@^6.2.1", "@metamask/rpc-errors@^6.3.1", "@metamask/rpc-errors@^7.0.0", "@metamask/rpc-errors@^7.0.1":
   version "7.0.1"