Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix/erc20 allowance ui #2103

Merged
merged 2 commits into from
Jan 21, 2021
Merged

bugfix/erc20 allowance ui #2103

merged 2 commits into from
Jan 21, 2021

Conversation

estebanmino
Copy link
Contributor

Description

Write a short description of the changes included in this pull request.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

Issue

Resolves #2017

@estebanmino estebanmino requested a review from a team as a code owner January 7, 2021 20:22
@ibrahimtaveras00 ibrahimtaveras00 added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 21, 2021
ibrahimtaveras00
ibrahimtaveras00 suggested changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue 1 from #1914 is fixed, however issue 2 still remains

Here I am requesting 1003 HOT and when I end up on the confirm view, I see < 0.00001 HOT instead

@ibrahimtaveras00 ibrahimtaveras00 added QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Jan 21, 2021
@ibrahimtaveras00
Copy link
Contributor

sorry meant for this comment to be for #2104

@ibrahimtaveras00 ibrahimtaveras00 added QA in Progress QA has started on the feature. and removed QA'd - Issues Found QA has been complete, however issues have been discovered that need to be addressed labels Jan 21, 2021
ibrahimtaveras00
ibrahimtaveras00 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Allowance now displays correct value, QA Passed 👍🏽

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Jan 21, 2021
@estebanmino estebanmino merged commit d8564fd into develop Jan 21, 2021
@estebanmino estebanmino deleted the bugfix/erc20-allowance-ui branch January 21, 2021 22:10
rickycodes pushed a commit that referenced this pull request Jan 31, 2022
@estebanmino
bugfix/erc20 allowance ui (#2103)
36a081a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickycodes rickycodes rickycodes approved these changes

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees
No one assigned
Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
3 participants
@estebanmino @ibrahimtaveras00 @rickycodes