Swaps: Add priceSlippage alert #2151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit d552524 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Tue Nov 17 14:05:22 2020 -0300 Remove unnecessary styling commit 24b5456 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Tue Nov 17 13:13:16 2020 -0300 Update tokens dependency for effect commit 1662700 Author: Esteban Mino <[email protected]> Date: Tue Nov 17 12:50:48 2020 -0300 bumpcontrollers commit 94a14dd Author: Pedro Pablo Aste Kompen <[email protected]> Date: Mon Nov 16 13:52:01 2020 -0300 Update main navigation snapshot commit f9ba8af Author: Pedro Pablo Aste Kompen <[email protected]> Date: Mon Nov 16 13:43:14 2020 -0300 Add TokenSelectButton label prop to test commit 637452f Author: Pedro Pablo Aste Kompen <[email protected]> Date: Mon Nov 16 13:34:37 2020 -0300 Add i18n to swaps amount view commit 6dfd9a4 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Fri Nov 13 15:52:21 2020 -0300 Fix TokenIcon border radius commit 54c17c2 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Fri Nov 13 13:30:16 2020 -0300 Remove unused key in token search for swaps commit 4bb4bcb Author: Pedro Pablo Aste Kompen <[email protected]> Date: Thu Nov 12 23:30:58 2020 -0300 Add asset balance in swaps amount view commit b262b4e Author: Pedro Pablo Aste Kompen <[email protected]> Date: Thu Nov 12 22:48:36 2020 -0300 Add token balances in token search modal list commit 6ca34c9 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Thu Nov 12 14:04:33 2020 -0300 Add invalid decimal warning commit 539d1e7 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Wed Nov 11 23:11:26 2020 -0300 Add empty list message and clear search on modal hide commit 65a31a6 Author: Esteban Mino <[email protected]> Date: Wed Nov 11 22:00:20 2020 -0300 bumpcontrollers commit 36a2289 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Wed Nov 11 19:18:40 2020 -0300 Update Receiver Modal snapshot, it uses ModalHandler now commit c69c414 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Wed Nov 11 19:13:31 2020 -0300 Add tokens from SwapsController commit 4f4e87f Author: Esteban Mino <[email protected]> Date: Tue Nov 10 21:57:42 2020 -0300 inception commit 2367393 Author: Esteban Mino <[email protected]> Date: Tue Nov 10 19:09:15 2020 -0300 package commit 707b491 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Wed Nov 11 17:49:41 2020 -0300 Add Initial Token Selector with dummy tokens commit 8644be0 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Tue Nov 10 12:40:34 2020 -0300 Switch Swaps feature flag to false commit 0696f10 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Mon Nov 9 20:40:44 2020 -0300 Add Keypad rules and swap token button commit 3173290 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Fri Nov 6 17:08:56 2020 -0300 Update snapshot for main nav commit 5f03198 Author: Pedro Pablo Aste Kompen <[email protected]> Date: Fri Nov 6 12:41:01 2020 -0300 Add SWAPS.ACTIVE flag
…ask-mobile into feature/swaps-quotes-view
estebanmino
changed the base branch from
develop
to
feature/swaps-quotes-view
estebanmino
reviewed
Jan 21, 2021
wachunei
changed the base branch from
feature/swaps-quotes-view
to
feature/swaps-alpha-2
…tamask-mobile into feature/swaps-slippage-alert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the price slippage alert.
Remains a draft since API is returning wrong ETH values, will update once this is resolved.This is going to be fixed in the API. Marking as ready for review.Checklist
Issue
Resolves #2090