Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swaps: Alpha 2 #2157

Merged
merged 96 commits into from
Mar 1, 2021
Merged

Swaps: Alpha 2 #2157

merged 96 commits into from
Mar 1, 2021

Conversation

wachunei
Copy link
Member

No description provided.

wachunei and others added 12 commits January 21, 2021 15:01
@wachunei @estebanmino
@flamingyawn @tlip
Swaps: Add priceSlippage alert (#2151)
a804b31 
Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
Co-authored-by: Esteban Mino <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: tlip <[email protected]>
@wachunei
Swaps: Add verify token message and link (#2132)
8d3ea69
@wachunei @rickycodes
Swaps: Add action button and SwapsLiveness component (#2117)
2bda334 
Co-authored-by: Ricky Miller <[email protected]>
@wachunei @rickycodes
Swaps: Asset selector ordering (#2121)
d647e23 
Co-authored-by: Ricky Miller <[email protected]>
@wachunei @estebanmino
@flamingyawn @tlip
Swaps: Loading Animation 🦊 (#2105)
e51bab3 
Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
Co-authored-by: Esteban Mino <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: tlip <[email protected]>
@wachunei @rekmarks
@estebanmino @flamingyawn @tlip @andrepimenta
Swaps: Add fiat amount in preferred currency (#2135)
9f0d233 
Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Esteban Mino <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: Andre Pimenta <[email protected]>
@estebanmino
REVERTTHIS
5354fe9
@estebanmino
REVERTTHISAGAIN
7824a31
@estebanmino
ifactive
83582fe
@estebanmino
active
6aba101
@estebanmino
Merge branch 'engine-swaps-flag' into feature/swaps-alpha-2
d19230c
@wachunei
Swaps: Fix amount and use max in amount view (#2159)
f49901a
@estebanmino estebanmino marked this pull request as ready for review January 26, 2021 20:06
@estebanmino estebanmino requested a review from a team as a code owner January 26, 2021 20:06
@ibrahimtaveras00 ibrahimtaveras00 added the QA in Progress QA has started on the feature. label Feb 25, 2021
@ibrahimtaveras00 ibrahimtaveras00 self-assigned this Feb 25, 2021
wachunei and others added 10 commits February 25, 2021 21:59
@wachunei
Remove settimeout 0 on complete (#2300)
03c9f2a
@estebanmino
585
47c4625
@estebanmino
Transactions destination amount default (#2305)
dee0f44 
* changeifdefined

* decimalPlaces

* saveamountsasminimalunit

* bump

* test

* updateswapsbeforeanalytics

* test
@estebanmino
586
3a3f75f
@estebanmino
swaps approval label (#2310)
a82b7bb 
* fix

* fix
@wachunei
Add props to hide selectors from gas edit modal (#2311)
6baba1b
@ejwessel @estebanmino
Switch Naming of Metrics (#2312)
d4a562b 
* Switch Naming of Metrics

* REVERTTHIS

* Revert "REVERTTHIS"

This reverts commit ed7c90d.

* rmcomment

* SWAP_TRACKING_FAILED

Co-authored-by: Esteban Mino <[email protected]>
@estebanmino
mergedev
06e7a43
@estebanmino
587
f7f11c7
@estebanmino
flags
9c095d8
ibrahimtaveras00
ibrahimtaveras00 approved these changes Mar 1, 2021
View reviewed changes
Copy link
Contributor

@ibrahimtaveras00 ibrahimtaveras00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alpha QA Passed ✅
ready for beta

@ibrahimtaveras00 ibrahimtaveras00 added QA Passed A successful QA run through has been done and removed QA in Progress QA has started on the feature. labels Mar 1, 2021
@wachunei wachunei merged commit 806665f into develop Mar 1, 2021
@wachunei wachunei deleted the feature/swaps-alpha-2 branch March 1, 2021 22:22
rickycodes added a commit that referenced this pull request Jan 31, 2022
@wachunei @estebanmino
@flamingyawn @tlip @rickycodes @rekmarks @andrepimenta @shibbyy @ejwessel
Swaps: Alpha 2 (#2157)
c0c6e54 
Co-authored-by: Pedro Pablo Aste Kompen <[email protected]>
Co-authored-by: Esteban Mino <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: tlip <[email protected]>
Co-authored-by: Ricky Miller <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Erik Marks <[email protected]>
Co-authored-by: Andre Pimenta <[email protected]>
Co-authored-by: Shivam Chaturvedi <[email protected]>
Co-authored-by: ricky <[email protected]>
Co-authored-by: ricky <[email protected]>
Co-authored-by: andrepimenta <[email protected]>
Co-authored-by: Ethan Wessel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@estebanmino estebanmino estebanmino left review comments

@ibrahimtaveras00 ibrahimtaveras00 ibrahimtaveras00 approved these changes

Assignees

@ibrahimtaveras00 ibrahimtaveras00

Labels
QA Passed A successful QA run through has been done
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wachunei @estebanmino @ibrahimtaveras00 @ejwessel